AMashenkov commented on code in PR #1191:
URL: https://github.com/apache/ignite-3/pull/1191#discussion_r1003170139
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##########
@@ -380,6 +403,50 @@ private SortedIndexDescriptor convert(SortedIndexView
indexView) {
);
}
+ private CompletableFuture<BinaryTuple> toIndexKey(TableIndexView
indexView, BinaryRow tableRow) {
+ return tableManager.tableAsyncInternal(indexView.tableId(),
false).thenApply(table -> {
Review Comment:
This looks like a temporary method, which is going to be refactored later.
Agree, seem, SchemaManager#tableSchema resolves the next Alex concern about
late schema version registration in local registry.
As of now, TableStorage returns BinaryRows as is instead of BinaryTuples and
doesn't care about the schema version.
If there is a guarantee that every request\query in transaction will deal
with the same schema version, and the rows are converted\upgraded to the same
schema version somewhere behind Table Bridge Interface, then this method will
be reducted to trivial conversion (just copy indexed column to a new binary
tuple).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
