[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1236: IGNITE-17941 Add learners to Raft API

[GitBox]

ibessonov commented on code in PR #1236:
URL: https://github.com/apache/ignite-3/pull/1236#discussion_r1003280287


##########
modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItLearnersTest.java:
##########
@@ -73,19 +77,38 @@
  */
 @ExtendWith(ConfigurationExtension.class)
 public class ItLearnersTest extends IgniteAbstractTest {
-    private static final String RAFT_GROUP_NAME = "test";
+    private static final ReplicationGroupId RAFT_GROUP_ID = new 
ReplicationGroupId() {
+        @Override
+        public String toString() {
+            return "test";

Review Comment:
   Didn't noticed that at first



##########
modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItLearnersTest.java:
##########
@@ -73,19 +77,38 @@
  */
 @ExtendWith(ConfigurationExtension.class)
 public class ItLearnersTest extends IgniteAbstractTest {
-    private static final String RAFT_GROUP_NAME = "test";
+    private static final ReplicationGroupId RAFT_GROUP_ID = new 
ReplicationGroupId() {
+        @Override
+        public String toString() {
+            return "test";
+        }
+    };
 
     private static final List<NetworkAddress> ADDRS = List.of(
             new NetworkAddress("localhost", 5000),
             new NetworkAddress("localhost", 5001),
             new NetworkAddress("localhost", 5002)
     );
 
+    private static final TestRaftMessagesFactory msgFactory = new 
TestRaftMessagesFactory();

Review Comment:
   You know what I mean)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org