sergey-chugunov-1985 commented on code in PR #1235:
URL: https://github.com/apache/ignite-3/pull/1235#discussion_r1003281482
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/command/PartitionCommand.java:
##########
@@ -18,31 +18,19 @@
package org.apache.ignite.internal.table.distributed.command;
import java.util.UUID;
+
+import org.apache.ignite.internal.table.distributed.TableMessageGroup;
+import org.apache.ignite.network.NetworkMessage;
+import org.apache.ignite.network.annotations.Transferable;
import org.apache.ignite.raft.client.WriteCommand;
-import org.jetbrains.annotations.NotNull;
/**
* Partition transactional command.
*/
-public abstract class PartitionCommand implements WriteCommand {
- /** Transaction id. */
- private UUID txId;
-
- /**
- * The constructor.
- *
- * @param txId Transaction id.
- */
- public PartitionCommand(@NotNull UUID txId) {
- this.txId = txId;
- }
-
+@Transferable(TableMessageGroup.Commands.PARTITION)
Review Comment:
You're right, I removed PARTITION message type from message group and
Transferrable annotation here.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/command/PartitionCommand.java:
##########
@@ -18,31 +18,19 @@
package org.apache.ignite.internal.table.distributed.command;
import java.util.UUID;
+
+import org.apache.ignite.internal.table.distributed.TableMessageGroup;
+import org.apache.ignite.network.NetworkMessage;
+import org.apache.ignite.network.annotations.Transferable;
import org.apache.ignite.raft.client.WriteCommand;
-import org.jetbrains.annotations.NotNull;
/**
* Partition transactional command.
*/
-public abstract class PartitionCommand implements WriteCommand {
- /** Transaction id. */
- private UUID txId;
-
- /**
- * The constructor.
- *
- * @param txId Transaction id.
- */
- public PartitionCommand(@NotNull UUID txId) {
- this.txId = txId;
- }
-
+@Transferable(TableMessageGroup.Commands.PARTITION)
Review Comment:
You're right, I removed PARTITION message type from message group and
Transferrable annotation from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
