sanpwc commented on code in PR #1230:
URL: https://github.com/apache/ignite-3/pull/1230#discussion_r1003540782
##########
modules/table/src/main/java/org/apache/ignite/internal/table/InternalTable.java:
##########
@@ -210,9 +242,26 @@ public interface InternalTable extends AutoCloseable {
* @param p The partition.
* @param tx The transaction.
* @return {@link Publisher} that reactively notifies about partition rows.
+ * @throws IllegalArgumentException If proposed partition index {@code p}
is out of bounds.
*/
Publisher<BinaryRow> scan(int p, @Nullable InternalTransaction tx);
+ /**
+ * Scans given partition within the context of a read-only transaction,
providing {@link Publisher} that reactively notifies about
+ * partition rows.
+ *
+ * @param p The partition.
+ * @param tx The transaction.
+ * @return {@link Publisher} that reactively notifies about partition rows.
+ * @throws IllegalArgumentException If proposed partition index {@code p}
is out of bounds.
+ * @throws TransactionException If proposed {@code tx} is read-write.
Transaction itself won't be automatically rolled back.
+ */
+ Publisher<BinaryRow> scan(
+ int p,
+ @Nullable InternalTransaction tx,
+ @NotNull ClusterNode recipientNode
Review Comment:
Fixed.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/InternalTable.java:
##########
@@ -77,6 +95,20 @@ public interface InternalTable extends AutoCloseable {
*/
CompletableFuture<Collection<BinaryRow>> getAll(Collection<BinaryRowEx>
keyRows, @Nullable InternalTransaction tx);
+ /**
+ * Asynchronously get rows from the table within the context of read-only
transaction.
+ *
+ * @param keyRows Rows with key columns set.
+ * @param tx The transaction.
+ * @return Future representing pending completion of the operation.
+ */
+ CompletableFuture<Collection<BinaryRow>> getAll(
+ Collection<BinaryRowEx> keyRows,
+ @Nullable InternalTransaction tx,
+ @NotNull ClusterNode recipientNode
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
