sanpwc commented on code in PR #1177:
URL: https://github.com/apache/ignite-3/pull/1177#discussion_r1004369589
##########
modules/core/src/main/java/org/apache/ignite/hlc/HybridClock.java:
##########
@@ -40,13 +47,25 @@ public class HybridClock {
}
/** Latest timestamp. */
- private volatile HybridTimestamp latestTime;
+ protected volatile HybridTimestamp latestTime;
Review Comment:
I don't like an idea of adding test related code to HybridClock. Neither
supplier nor protected or TestOnly. I'd rather extract HybridClock interface
with several implementaions, e.g. common HybridClockImpl and
TrackableHybridClock in test package. What do u think, will it work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
