korlov42 commented on code in PR #1191:
URL: https://github.com/apache/ignite-3/pull/1191#discussion_r1005303647
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -302,30 +256,14 @@ private void handleTxCleanupCommand(TxCleanupCommand cmd,
long commandIndex) {
storage.runConsistently(() -> {
UUID txId = cmd.txId();
- Set<ByteBuffer> removedKeys = txsRemovedKeys.getOrDefault(txId,
Collections.emptySet());
-
- Set<ByteBuffer> insertedKeys = txsInsertedKeys.getOrDefault(txId,
Collections.emptySet());
-
Set<RowId> pendingRowIds = txsPendingRowIds.getOrDefault(txId,
Collections.emptySet());
if (cmd.commit()) {
pendingRowIds.forEach(rowId -> storage.commitWrite(rowId,
cmd.commitTimestamp()));
} else {
- pendingRowIds.forEach(rowId -> storage.abortWrite(rowId));
+ pendingRowIds.forEach(storage::abortWrite);
Review Comment:
Yes, this patch is already to big, so I decided to slit clean up part to
https://issues.apache.org/jira/browse/IGNITE-17974, if you don't mind
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -302,30 +256,14 @@ private void handleTxCleanupCommand(TxCleanupCommand cmd,
long commandIndex) {
storage.runConsistently(() -> {
UUID txId = cmd.txId();
- Set<ByteBuffer> removedKeys = txsRemovedKeys.getOrDefault(txId,
Collections.emptySet());
-
- Set<ByteBuffer> insertedKeys = txsInsertedKeys.getOrDefault(txId,
Collections.emptySet());
-
Set<RowId> pendingRowIds = txsPendingRowIds.getOrDefault(txId,
Collections.emptySet());
if (cmd.commit()) {
pendingRowIds.forEach(rowId -> storage.commitWrite(rowId,
cmd.commitTimestamp()));
} else {
- pendingRowIds.forEach(rowId -> storage.abortWrite(rowId));
+ pendingRowIds.forEach(storage::abortWrite);
Review Comment:
Yes, this patch is already too big, so I decided to slit clean up part to
https://issues.apache.org/jira/browse/IGNITE-17974, if you don't mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
