SammyVimes commented on code in PR #1246:
URL: https://github.com/apache/ignite-3/pull/1246#discussion_r1007086599
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/outgoing/SnapshotAwarePartitionDataStorage.java:
##########
@@ -84,33 +92,31 @@ public void lastAppliedIndex(long lastAppliedIndex) throws
StorageException {
@Override
public @Nullable BinaryRow addWrite(RowId rowId, @Nullable BinaryRow row,
UUID txId, UUID commitTableId,
int commitPartitionId) throws TxIdMismatchException,
StorageException {
- sendRowOutOfOrderToInterferingSnapshots(rowId);
+ sendMvRowOutOfOrderToInterferingSnapshots(rowId);
return partitionStorage.addWrite(rowId, row, txId, commitTableId,
commitPartitionId);
}
@Override
public @Nullable BinaryRow abortWrite(RowId rowId) throws StorageException
{
- sendRowOutOfOrderToInterferingSnapshots(rowId);
+ sendMvRowOutOfOrderToInterferingSnapshots(rowId);
return partitionStorage.abortWrite(rowId);
}
@Override
public void commitWrite(RowId rowId, HybridTimestamp timestamp) throws
StorageException {
- sendRowOutOfOrderToInterferingSnapshots(rowId);
+ sendMvRowOutOfOrderToInterferingSnapshots(rowId);
Review Comment:
I have to agree with Ivan here. I think such naming can only be used for
tests (probably, with name argument of the annotation). For business logic it's
really hard to understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
