[GitHub] [ignite-3] sanpwc commented on a diff in pull request #1262: IGNITE-17983 Fix work with the last applied index in RAFT

Fri, 28 Oct 2022 00:13:49 -0700 


sanpwc commented on code in PR #1262:
URL: https://github.com/apache/ignite-3/pull/1262#discussion_r1007728787


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -287,16 +291,15 @@ private void 
handleSafeTimeSyncCommand(SafeTimeSyncCommand cmd) {
     /** {@inheritDoc} */
     @Override
     public void onSnapshotSave(Path path, Consumer<Throwable> doneClo) {
-        storage.flush();
+        CompletableFuture.allOf(storage.flush(), txStateStorage.flush())

Review Comment:
   max index setting is missing
   ```
           long maxLastAppliedIndex = Math.max(storage.lastAppliedIndex(), 
txStateStorage.lastAppliedIndex());
           storage.lastAppliedIndex(maxLastAppliedIndex);
           txStateStorage.lastAppliedIndex(maxLastAppliedIndex);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to