sanpwc commented on code in PR #1263:
URL: https://github.com/apache/ignite-3/pull/1263#discussion_r1007883308
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -108,19 +108,20 @@ public void onRead(Iterator<CommandClosure<ReadCommand>>
iterator) {
});
}
- /** {@inheritDoc} */
@Override
public void onWrite(Iterator<CommandClosure<WriteCommand>> iterator) {
iterator.forEachRemaining((CommandClosure<? extends WriteCommand> clo)
-> {
Command command = clo.command();
long commandIndex = clo.index();
- long storageAppliedIndex = storage.lastAppliedIndex();
+ // We choose the minimum applied index, since we choose it (the
minimum one) on local recovery so as not to lose the data for
+ // one of the storages.
+ long storagesAppliedIndex = Math.min(storage.lastAppliedIndex(),
txStateStorage.lastAppliedIndex());
Review Comment:
That means, that we should add storage specific skip logic. Probably inside
storage. Or we already have it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
