xtern commented on code in PR #1237:
URL: https://github.com/apache/ignite-3/pull/1237#discussion_r1009596956
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/LogicalRelImplementor.java:
##########
@@ -305,7 +305,7 @@ public Node<RowT> visit(IgniteIndexScan rel) {
ColocationGroup group = ctx.group(rel.sourceId());
int[] parts = group.partitions(ctx.localNodeId());
- return new IndexScanNode<>(ctx, rowType, idx, tbl, parts, ranges,
filters, prj, requiredColumns.toBitSet());
+ return new IndexScanNode<>(ctx, rowType, idx, tbl, parts,
rel.collation(), ranges, filters, prj, requiredColumns.toBitSet());
Review Comment:
Yes, we can, but from my point of view - it will be more error prone. Why do
you think that it will be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
