sergey-chugunov-1985 commented on code in PR #1235:
URL: https://github.com/apache/ignite-3/pull/1235#discussion_r1012842077
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -979,9 +1064,17 @@ private CompletableFuture<Object>
processSingleEntryAction(ReadWriteSingleRowRep
return lockFut.thenCompose(lockedRowId -> {
boolean inserted = lockedRowId == null;
- CompletableFuture raftFut =
+ CompletableFuture<Object> raftFut =
lockedRowId == null ?
applyCmdWithExceptionHandling(
- new UpdateCommand(commitPartitionId, new
RowId(partId), searchRow, txId)) :
+ msgFactory.updateCommand()
+
.tablePartitionId(msgFactory.tablePartitionIdMessage()
+
.tableId(commitPartitionId.getTableId())
+
.partitionId(commitPartitionId.getPartId())
+ .build())
+
.rowUuid(Timestamp.nextVersion().toUuid())
Review Comment:
I reviewed the code and it seems that all these occurrences are gone after
latest main merged, so I'm ignoring this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]