rpuch commented on code in PR #1291:
URL: https://github.com/apache/ignite-3/pull/1291#discussion_r1013030298
##########
modules/metastorage-server/src/main/java/org/apache/ignite/internal/metastorage/server/raft/MetaStorageListener.java:
##########
@@ -418,7 +418,7 @@ public boolean onSnapshotLoad(Path path) {
public void onShutdown() {
try {
storage.close();
- } catch (Exception e) {
+ } catch (RuntimeException e) {
Review Comment:
Before, we were handling ANYTHING. Now we handle a lot less; but the idea to
catch `RuntimeException` was to keep the old behavior.
Should I remove the try/catch altogether?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
