sashapolo commented on code in PR #1309:
URL: https://github.com/apache/ignite-3/pull/1309#discussion_r1013728700
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java:
##########
@@ -143,16 +140,20 @@ public class ItIgniteNodeRestartTest extends
IgniteAbstractTest {
+ " network.nodeFinder.netClusterNodes: {}\n"
+ "}";
- /** Cluster nodes. */
- private static final List<Ignite> CLUSTER_NODES = new ArrayList<>();
+ @InjectConfiguration
+ private static RaftConfiguration raftConfiguration;
- private static final List<String> CLUSTER_NODES_NAMES = new ArrayList<>();
+ private final List<String> clusterNodesNames = new ArrayList<>();
Review Comment:
We can start a node on another thread, but adding a node name to this list
always happens in the thread that calls the `startNode` method, so this
collection is never accessed concurrently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
