sashapolo commented on code in PR #1267: URL: https://github.com/apache/ignite-3/pull/1267#discussion_r1019006947
########## modules/cli/src/main/java/org/apache/ignite/internal/cli/NodeNameRegistry.java: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.cli; + +import static org.apache.ignite.internal.util.IgniteUtils.shutdownAndAwaitTermination; + +import jakarta.inject.Singleton; +import java.net.URL; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeUnit; +import java.util.stream.Collectors; +import org.apache.ignite.internal.cli.call.cluster.topology.PhysicalTopologyCall; +import org.apache.ignite.internal.cli.core.call.UrlCallInput; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.logger.Loggers; +import org.apache.ignite.internal.thread.NamedThreadFactory; +import org.apache.ignite.rest.client.model.ClusterNode; +import org.apache.ignite.rest.client.model.NodeMetadata; +import org.jetbrains.annotations.Nullable; + +/** + * Registry to get a node URL by a node name. + */ +@Singleton +public class NodeNameRegistry { + + private final IgniteLogger log = Loggers.forClass(getClass()); + private volatile Map<String, URL> nodeNameToNodeUrl = new HashMap<>(); + private ScheduledExecutorService executor; + + /** + * Start pulling updates from a node. + * + * @param nodeUrl Node URL. + */ + public synchronized void startPullingUpdates(String nodeUrl) { + stopPullingUpdates(); + if (executor == null) { + executor = Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("NodeNameRegistry", log)); + executor.scheduleWithFixedDelay(() -> updateNodeNames(nodeUrl), 0, 5, TimeUnit.SECONDS); + } + } + + /** + * Gets a node url by a provided node name. + */ + public Optional<URL> getNodeUrl(String nodeName) { + return Optional.ofNullable(nodeNameToNodeUrl.get(nodeName)); + } + + /** + * Gets all node names. + */ + public List<String> getAllNames() { + return new ArrayList<>(nodeNameToNodeUrl.keySet()); Review Comment: This map is now immutable, so no need to worry. If you are concerned about someone modifying the returned set, then this will be handled by the `Collectors.toImmutableMap` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
