sanpwc commented on code in PR #1327:
URL: https://github.com/apache/ignite-3/pull/1327#discussion_r1019882616
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/TableScanNodeExecutionTest.java:
##########
@@ -155,7 +157,11 @@ public TestInternalTableImpl(
mock(MvTableStorage.class),
mock(TxStateTableStorage.class),
replicaSvc,
- mock(HybridClock.class)
+ mock(HybridClock.class),
+ new ScheduledThreadPoolExecutor(
+ Runtime.getRuntime().availableProcessors(),
+ new
NamedThreadFactory("internal-table-scheduled-pool", log)
Review Comment:
Well, I have to admit that proposed solution doesn't look good, despite the
fact that I've pre-approved it earlier. new ScheduledThreadPoolExecutor() as a
parameter looks crappy. In all that cases we need to shutdown an executors, etc.
So, let's consider other solutions, e.g. registering listener within
replicaManager that will trigger reactive notification about replica appearance
in the map. Will provide more details during the sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
