AMashenkov commented on code in PR #1334:
URL: https://github.com/apache/ignite-3/pull/1334#discussion_r1022527205
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/RootNode.java:
##########
@@ -64,28 +63,41 @@
* TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
*
* @param ctx Execution context.
- * @param rowType Rel data type.
*/
- public RootNode(ExecutionContext<RowT> ctx, RelDataType rowType) {
- super(ctx, rowType);
+ public RootNode(ExecutionContext<RowT> ctx) {
+ super(ctx);
onClose = this::closeInternal;
- converter = TypeUtils.resultTypeConverter(ctx, rowType);
+ converter = Functions.identity();
}
/**
* Constructor.
* TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
*
* @param ctx Execution context.
- * @param rowType Rel data type.
+ * @param converter Output rows converter.
+ */
+ public RootNode(ExecutionContext<RowT> ctx, Function<RowT, RowT>
converter) {
+ super(ctx);
Review Comment:
```suggestion
this(ctx, converter, this::closeInternal);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
