nizhikov commented on code in PR #10314:
URL: https://github.com/apache/ignite/pull/10314#discussion_r1027705622
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxFinishFuture.java:
##########
@@ -239,7 +241,21 @@ public void onResult(UUID nodeId, GridDhtTxFinishResponse
res) {
try {
boolean nodeStopping = X.hasCause(err,
NodeStoppingException.class);
- this.tx.tmFinish(err == null, nodeStopping ||
cctx.kernalContext().failure().nodeStopping(), false);
+ if (cctx.consistentCutMgr() != null &&
this.tx.currentPrepareFuture() != null) {
Review Comment:
Can we
a. rework logic to avoid `cctx.consistentCutMgr() != null` checks.
b. use NoOp or disabled implementation of cut manager in case it can't be
used.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxFinishFuture.java:
##########
@@ -239,7 +241,21 @@ public void onResult(UUID nodeId, GridDhtTxFinishResponse
res) {
try {
boolean nodeStopping = X.hasCause(err,
NodeStoppingException.class);
- this.tx.tmFinish(err == null, nodeStopping ||
cctx.kernalContext().failure().nodeStopping(), false);
+ if (cctx.consistentCutMgr() != null &&
this.tx.currentPrepareFuture() != null) {
Review Comment:
Can we?
a. rework logic to avoid `cctx.consistentCutMgr() != null` checks.
b. use NoOp or disabled implementation of cut manager in case it can't be
used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
