ptupitsyn commented on code in PR #10388:
URL: https://github.com/apache/ignite/pull/10388#discussion_r1028196338
##########
modules/platforms/cpp/core/src/ignition.cpp:
##########
@@ -149,6 +149,24 @@ namespace ignite
opts.push_back(CopyChars("--add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED"));
opts.push_back(CopyChars("--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED"));
opts.push_back(CopyChars("--illegal-access=permit"));
+
+ // Those are only needed for Java 15+, but Java 15 can not be
detected easily using JNI,
+ // so just putting it here in case we are running on 15+. It
is OK to have them on Java 9-14 too.
Review Comment:
We can add a link to
https://docs.oracle.com/en/java/javase/17/docs/specs/jni/functions.html#getversion,
which shows why it is not possible to detect Java version with JNI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
