ashapkin commented on code in PR #185:
URL: https://github.com/apache/ignite-extensions/pull/185#discussion_r1029855266
##########
modules/spark-ext/spark/src/main/scala/org/apache/spark/sql/ignite/IgniteSparkSession.scala:
##########
@@ -142,7 +142,7 @@ class IgniteSparkSession private(
override def createDataset[T: Encoder](data: Seq[T]): Dataset[T] = {
val enc = encoderFor[T]
val attributes = enc.schema.toAttributes
- val encoded = data.map(d => enc.toRow(d).copy())
+ val encoded = data.map(d => enc.createSerializer().apply(d)) // TODO
.copy()?
Review Comment:
Unfortunately, I'm not the author of that change, so I'd better remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
