tkalkirill commented on code in PR #1325:
URL: https://github.com/apache/ignite-3/pull/1325#discussion_r1030800869
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/store/FilePageStoreManager.java:
##########
@@ -75,52 +93,44 @@ public class FilePageStoreManager implements
PageReadWriteManager {
/** Group directory prefix. */
public static final String GROUP_DIR_PREFIX = "table-";
- /** Logger. */
- private final IgniteLogger log;
-
/** Starting directory for all file page stores, for example:
'db/group-123/index.bin'. */
private final Path dbDir;
/** Page size in bytes. */
private final int pageSize;
- /**
- * Executor to disallow running code that modifies data in {@link
#groupPageStores} concurrently with cleanup of file page store.
- */
+ /** Executor to disallow running code that modifies data in {@link
#groupPageStores} concurrently with cleanup of file page store. */
private final LongOperationAsyncExecutor cleanupAsyncExecutor;
- /** Mapping: group ID -> page store list. */
+ /** Mapping: group ID -> group page stores. */
private final GroupPageStoresMap<FilePageStore> groupPageStores;
- /** Group directory initialization lock. */
- private final IgniteStripedLock initGroupDirLock = new
IgniteStripedLock(Math.max(Runtime.getRuntime().availableProcessors(), 8));
+ /** Striped lock. */
+ private final IgniteStripedLock stripedLock = new
IgniteStripedLock(Math.max(Runtime.getRuntime().availableProcessors(), 8));
Review Comment:
Sounds reasonable, tried to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
