ibessonov commented on code in PR #1325:
URL: https://github.com/apache/ignite-3/pull/1325#discussion_r1032127644
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpointer.java:
##########
@@ -452,9 +456,21 @@ private void syncUpdatedPageStores(
return;
}
- fsyncDeltaFilePageStoreOnCheckpointThread(entry.getKey(),
entry.getValue());
+ GroupPartitionId partitionId = entry.getKey();
+
+ FilePageStore filePageStore =
filePageStoreManager.getStore(partitionId.getGroupId(),
partitionId.getPartitionId());
+
+ if (filePageStore == null ||
filePageStore.isMarkedToDestroy()) {
Review Comment:
How can it have 332 lines if github shows lines 460-463 in this particular
comment? I agree with Roman, it looks very much like code duplication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
