vldpyatkov commented on code in PR #1366:
URL: https://github.com/apache/ignite-3/pull/1366#discussion_r1033200216
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/LeaderOrTxState.java:
##########
@@ -20,35 +20,34 @@
import java.io.Serializable;
import org.apache.ignite.internal.tx.TxMeta;
import org.apache.ignite.internal.tx.message.TxStateReplicaRequest;
-import org.apache.ignite.network.ClusterNode;
import org.jetbrains.annotations.Nullable;
/**
- * Response for the {@link TxStateReplicaRequest}. Can contain either the
Partition Group leader, which should be
+ * Response for the {@link TxStateReplicaRequest}. Can contain either the
consistent ID of the Partition Group leader, which should be
* queried for the TX Meta, or the TX Meta itself.
*/
public class LeaderOrTxState implements Serializable {
private static final long serialVersionUID = -3555591755828355117L;
@Nullable
- private final ClusterNode leader;
+ private final String leaderName;
Review Comment:
Why do not use consistent id instead of name here?
##########
modules/affinity/src/main/java/org/apache/ignite/internal/affinity/Assignment.java:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.affinity;
+
+import java.io.Serializable;
+
+/**
+ * Represent an assignment of a partition to a node with a specific {@code
consistentId}.
+ *
+ * <p>There can be two types of assignments: one for the voting members of the
partition Raft group (a.k.a. "peers") and one for
Review Comment:
The abstraction leak does not like to me. Even in comment, we can not use
concrete name of replication protocol.
This also applies to the terms peer and learner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
