tkalkirill commented on code in PR #1325:
URL: https://github.com/apache/ignite-3/pull/1325#discussion_r1033227518
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java:
##########
@@ -378,21 +381,38 @@ public RocksDbMvPartitionStorage
getOrCreateMvPartition(int partitionId) throws
}
@Override
- public void destroyPartition(int partitionId) throws StorageException {
+ public CompletableFuture<Void> destroyPartition(int partitionId) {
checkPartitionId(partitionId);
+ CompletableFuture<Void> destroyPartitionFuture = new
CompletableFuture<>();
+
+ CompletableFuture<Void> previousDestroyPartitionFuture =
partitionIdDestroyFutureMap.putIfAbsent(
+ partitionId,
+ destroyPartitionFuture
+ );
+
+ if (previousDestroyPartitionFuture != null) {
+ return previousDestroyPartitionFuture;
+ }
+
RocksDbMvPartitionStorage mvPartition =
partitions.getAndSet(partitionId, null);
if (mvPartition != null) {
- //TODO IGNITE-17626 Destroy indexes as well...
- mvPartition.destroy();
-
try {
+ //TODO IGNITE-17626 Destroy indexes as well...
+ mvPartition.destroy();
Review Comment:
Added a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
