timoninmaxim commented on code in PR #10318:
URL: https://github.com/apache/ignite/pull/10318#discussion_r1033227837
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheOperationContext.java:
##########
@@ -31,10 +32,17 @@
* Cache operation context.
*/
public class CacheOperationContext implements Serializable {
- /** */
- //TODO IGNITE-8801 remove this and set default as `false`.
- public static final boolean DFLT_ALLOW_ATOMIC_OPS_IN_TX =
Review Comment:
Let's keep this variable:
``
private static final boolean DFLT_ALLOW_ATOMIC_OPS_IN_TX = false;
public static final boolean defaultAllowAtomicOpsInTx() {
return IgniteSystemProperties.getBoolean(IGNITE_ALLOW_ATOMIC_OPS_IN_TX,
DFLT_ALLOW_ATOMIC_OPS_IN_TX);
}
```
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheOperationContext.java:
##########
@@ -31,10 +32,17 @@
* Cache operation context.
*/
public class CacheOperationContext implements Serializable {
- /** */
- //TODO IGNITE-8801 remove this and set default as `false`.
- public static final boolean DFLT_ALLOW_ATOMIC_OPS_IN_TX =
Review Comment:
Let's keep this variable:
```
private static final boolean DFLT_ALLOW_ATOMIC_OPS_IN_TX = false;
public static final boolean defaultAllowAtomicOpsInTx() {
return IgniteSystemProperties.getBoolean(IGNITE_ALLOW_ATOMIC_OPS_IN_TX,
DFLT_ALLOW_ATOMIC_OPS_IN_TX);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
