sergeyuttsel commented on code in PR #1369:
URL: https://github.com/apache/ignite-3/pull/1369#discussion_r1035003224
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -118,17 +120,42 @@ public ReplicaManager(
ReplicaRequest request = (ReplicaRequest) message;
- HybridTimestamp requestTimestamp = extractTimestamp(request);
+ if (request instanceof AwaitReplicaRequest) {
+ replicas.compute(request.groupId(), (replicationGroupId,
replicaFut) -> {
+ if (replicaFut == null) {
+ replicaFut = new CompletableFuture<>();
+ }
+
+ if (!replicaFut.isDone()) {
+ replicaFut.thenCompose(ignore -> {
+ IgniteUtils.inBusyLock(busyLock,
Review Comment:
fixed
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -118,17 +120,42 @@ public ReplicaManager(
ReplicaRequest request = (ReplicaRequest) message;
- HybridTimestamp requestTimestamp = extractTimestamp(request);
+ if (request instanceof AwaitReplicaRequest) {
Review Comment:
fixed
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -118,17 +120,42 @@ public ReplicaManager(
ReplicaRequest request = (ReplicaRequest) message;
- HybridTimestamp requestTimestamp = extractTimestamp(request);
+ if (request instanceof AwaitReplicaRequest) {
+ replicas.compute(request.groupId(), (replicationGroupId,
replicaFut) -> {
+ if (replicaFut == null) {
+ replicaFut = new CompletableFuture<>();
+ }
+
+ if (!replicaFut.isDone()) {
+ replicaFut.thenCompose(ignore -> {
+ IgniteUtils.inBusyLock(busyLock,
+ () -> sendAwaitReplicaResponse(sender,
correlationId));
+
+ return null;
+ });
+
+ return replicaFut;
+ } else {
+ IgniteUtils.inBusyLock(busyLock, () ->
sendAwaitReplicaResponse(sender, correlationId));
+
+ return replicaFut;
+ }
+ });
- Replica replica = replicas.get(request.groupId());
+ return;
+ }
+
+ CompletableFuture<Replica> replicaFut =
replicas.get(request.groupId());
+
+ HybridTimestamp requestTimestamp = extractTimestamp(request);
- if (replica == null) {
+ if (replicaFut == null || !replicaFut.isDone()) {
sendReplicaUnavailableErrorResponse(sender, correlationId,
request, requestTimestamp);
return;
}
- CompletableFuture<Object> result =
replica.processRequest(request);
+ CompletableFuture<Object> result =
replicaFut.join().processRequest(request);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
