xtern commented on code in PR #1385:
URL: https://github.com/apache/ignite-3/pull/1385#discussion_r1037135915
##########
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -151,8 +151,8 @@ public static class Sql {
/** Table version not found. */
public static final int TABLE_VER_NOT_FOUND_ERR =
SQL_ERR_GROUP.registerErrorCode(18);
- /** Invalid table option. */
Review Comment:
> the error code related to "create table syntax only
Yes, at the moment, but I think this error code may relate to any invalid
DDL statement option in future, why not?
But if you suggest making a separate error code for invalid `CREATE ZONE`
options, I can add it.
##########
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -151,8 +151,8 @@ public static class Sql {
/** Table version not found. */
public static final int TABLE_VER_NOT_FOUND_ERR =
SQL_ERR_GROUP.registerErrorCode(18);
- /** Invalid table option. */
Review Comment:
> the error code related to "create table syntax only
Yes, at the moment, but I think this error code may relate to any invalid
DDL statement option in future, why not?
But if you suggest making a separate error code for invalid `CREATE ZONE`
options, I can add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
