[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10396: Ignite-17793 : Historical rebalance must use HWM instead of LWM, v2: store pending counter instead

[GitBox]

Vladsz83 commented on code in PR #10396:
URL: https://github.com/apache/ignite/pull/10396#discussion_r1039397824


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/checkpoint/CheckpointWorkflow.java:
##########
@@ -396,10 +396,13 @@ private void fillCacheGroupState(CheckpointRecord cpRec) 
throws IgniteCheckedExc
                     if (partState == LOST)
                         partState = OWNING;
 
+                    assert part.highestAppliedCounter() >= 
part.updateCounter() :

Review Comment:
   There is no assert any more. But isn't it a bug with counter? Or what if 
just write highest applied ath the checkpoint time? Regarding to the data 
updated before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org