[GitHub] [ignite-3] rpuch commented on a diff in pull request #1412: IGNITE-18321 Return node to logical topology as soon as it gets returned to physical topology

Thu, 08 Dec 2022 03:23:15 -0800 


rpuch commented on code in PR #1412:
URL: https://github.com/apache/ignite-3/pull/1412#discussion_r1043245516


##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##########
@@ -420,7 +422,15 @@ private void handleClusterState(ClusterStateMessage msg, 
String senderConsistent
                             if (service != null && 
service.nodeNames().equals(state.cmgNodes())) {
                                 LOG.info("ClusterStateMessage received, but 
the CMG service is already started");
 
-                                return completedFuture(service);
+                                return joinCluster(service, state.clusterTag())

Review Comment:
   Moved conditional join so that it is executed also in the case when CMG node 
set has changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to