korlov42 commented on code in PR #1427:
URL: https://github.com/apache/ignite-3/pull/1427#discussion_r1044173273
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/IgniteSchema.java:
##########
@@ -91,8 +90,6 @@ public void addTable(String tblName, InternalIgniteTable tbl)
{
public void removeTable(String tblName) {
InternalIgniteTable rmv = (InternalIgniteTable) tblMap.remove(tblName);
- // TODO: https://issues.apache.org/jira/browse/IGNITE-17474
- // Decouple tables and indices.
idxMap.values().removeIf(idx ->
idx.index().tableId().equals(rmv.id()));
Review Comment:
seems we don't need to do it anymore
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java:
##########
@@ -987,6 +996,220 @@ public <RowT> ModifyRow
toModifyRow(ExecutionContext<RowT> ectx, RowT row, Opera
}
}
+ /** Test purpose implementation. */
+ private static class TestInternalTableImpl implements InternalTable {
Review Comment:
I don't like the idea to create a 200 LOC stub just to return a table name.
Let's extend the IgniteTable interface with `String name()` method
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractAggregatePlannerTest.java:
##########
@@ -59,10 +59,11 @@ public IgniteDistribution distribution() {
* CreateAffinityTable.
* TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
Review Comment:
could you please fix the entire javadoc?
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManagerImpl.java:
##########
@@ -430,10 +430,8 @@ public synchronized CompletableFuture<?>
onIndexCreated(Index<?> index, long cau
return
CompletableFuture.completedFuture(resIdxs);
})
).thenCompose(ignore -> {
- String tblName = tableNameById(schema,
index.tableId());
Review Comment:
tableNameById is not used anymore
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractAggregatePlannerTest.java:
##########
@@ -32,10 +31,11 @@ public class AbstractAggregatePlannerTest extends
AbstractPlannerTest {
/**
* CreateBroadcastTable.
Review Comment:
improve please this javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
