tkalkirill commented on code in PR #1407:
URL: https://github.com/apache/ignite-3/pull/1407#discussion_r1044287065
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/index/AbstractSortedIndexStorageTest.java:
##########
@@ -579,6 +585,401 @@ void testNullValues(ColumnDefinition columnDefinition)
throws Exception {
}
}
+ /**
+ * Checks simple scenarios for a scanning cursor.
+ */
+ @Test
+ void testScanSimple() {
+ SortedIndexDefinition indexDefinition =
SchemaBuilders.sortedIndex("TEST_IDX")
+
.addIndexColumn(ColumnType.INT32.typeSpec().name()).asc().done()
+ .build();
+
+ SortedIndexStorage indexStorage = createIndexStorage(indexDefinition);
+
+ BinaryTupleRowSerializer serializer = new
BinaryTupleRowSerializer(indexStorage.indexDescriptor());
+
+ for (int i = 0; i < 5; i++) {
+ put(indexStorage, serializer.serializeRow(new Object[]{i}, new
RowId(TEST_PARTITION)));
+ }
+
+ // Checking without borders.
+ assertThat(
+ scan(indexStorage, null, null, 0).stream().map(objects ->
objects[0]).collect(toList()),
+ contains(0, 1, 2, 3, 4)
+ );
+
+ // Let's check without borders.
+ assertThat(
+ indexStorage.scan(
+ serializer.serializeRowPrefix(0),
+ serializer.serializeRowPrefix(4),
+ (GREATER_OR_EQUAL | LESS_OR_EQUAL)
+ ).stream()
+ .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
+ .collect(toList()),
+ contains(0, 1, 2, 3, 4)
+ );
+
+ assertThat(
+ indexStorage.scan(
+ serializer.serializeRowPrefix(0),
+ serializer.serializeRowPrefix(4),
+ (GREATER_OR_EQUAL | LESS)
+ ).stream()
+ .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
+ .collect(toList()),
+ contains(0, 1, 2, 3)
+ );
+
+ assertThat(
+ indexStorage.scan(
+ serializer.serializeRowPrefix(0),
+ serializer.serializeRowPrefix(4),
+ (GREATER | LESS_OR_EQUAL)
+ ).stream()
+ .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
+ .collect(toList()),
+ contains(1, 2, 3, 4)
+ );
+
+ assertThat(
+ indexStorage.scan(
+ serializer.serializeRowPrefix(0),
+ serializer.serializeRowPrefix(4),
+ (GREATER | LESS)
+ ).stream()
+ .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
+ .collect(toList()),
+ contains(1, 2, 3)
+ );
+
+ // Let's check only with the lower bound.
+ assertThat(
+ indexStorage.scan(
+ serializer.serializeRowPrefix(1),
+ null,
+ (GREATER_OR_EQUAL | LESS_OR_EQUAL)
+ ).stream()
+ .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
+ .collect(toList()),
+ contains(1, 2, 3, 4)
+ );
+
+ assertThat(
+ indexStorage.scan(
+ serializer.serializeRowPrefix(1),
+ null,
+ (GREATER_OR_EQUAL | LESS)
+ ).stream()
+ .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
+ .collect(toList()),
+ contains(1, 2, 3, 4)
+ );
+
+ assertThat(
+ indexStorage.scan(
+ serializer.serializeRowPrefix(1),
+ null,
+ (GREATER | LESS_OR_EQUAL)
+ ).stream()
+ .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
+ .collect(toList()),
+ contains(2, 3, 4)
+ );
+
+ assertThat(
+ indexStorage.scan(
+ serializer.serializeRowPrefix(1),
+ null,
+ (GREATER | LESS)
+ ).stream()
+ .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
+ .collect(toList()),
+ contains(2, 3, 4)
+ );
+
+ // Let's check only with the upper bound.
+ assertThat(
+ indexStorage.scan(
+ null,
+ serializer.serializeRowPrefix(3),
+ (GREATER_OR_EQUAL | LESS_OR_EQUAL)
+ ).stream()
+ .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
+ .collect(toList()),
+ contains(0, 1, 2, 3)
+ );
+
+ assertThat(
+ indexStorage.scan(
+ null,
+ serializer.serializeRowPrefix(3),
+ (GREATER_OR_EQUAL | LESS)
+ ).stream()
+ .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
+ .collect(toList()),
+ contains(0, 1, 2)
+ );
+
+ assertThat(
+ indexStorage.scan(
+ null,
+ serializer.serializeRowPrefix(3),
+ (GREATER | LESS_OR_EQUAL)
+ ).stream()
+ .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
+ .collect(toList()),
+ contains(0, 1, 2, 3)
+ );
+
+ assertThat(
+ indexStorage.scan(
+ null,
+ serializer.serializeRowPrefix(3),
+ (GREATER | LESS)
+ ).stream()
+ .map(indexRow ->
serializer.deserializeColumns(indexRow)[0])
+ .collect(toList()),
+ contains(0, 1, 2)
+ );
+ }
+
+ @Test
+ void testScanContractForEmptyIndex() {
+ SortedIndexDefinition indexDefinition =
SchemaBuilders.sortedIndex("TEST_IDX")
+
.addIndexColumn(ColumnType.INT32.typeSpec().name()).asc().done()
+ .build();
+
+ SortedIndexStorage indexStorage = createIndexStorage(indexDefinition);
+
+ BinaryTupleRowSerializer serializer = new
BinaryTupleRowSerializer(indexStorage.indexDescriptor());
+
+ Cursor<IndexRow> scanBeforeHashNext = indexStorage.scan(null, null, 0);
+
+ Cursor<IndexRow> scanAfterHasNext = indexStorage.scan(null, null, 0);
+
+ assertFalse(scanAfterHasNext.hasNext());
+
+ Cursor<IndexRow> scanWithoutHasNext = indexStorage.scan(null, null, 0);
+
+ put(indexStorage, serializer.serializeRow(new Object[]{0}, new
RowId(TEST_PARTITION)));
+
+ assertTrue(scanBeforeHashNext.hasNext());
+ assertFalse(scanAfterHasNext.hasNext());
+
+ assertEquals(0,
serializer.deserializeColumns(scanBeforeHashNext.next())[0]);
+
+ assertThrows(NoSuchElementException.class, scanAfterHasNext::next);
+ assertEquals(0,
serializer.deserializeColumns(scanAfterHasNext.next())[0]);
+
+ assertEquals(0,
serializer.deserializeColumns(scanWithoutHasNext.next())[0]);
+
+ assertFalse(scanBeforeHashNext.hasNext());
+ assertFalse(scanAfterHasNext.hasNext());
+ assertFalse(scanWithoutHasNext.hasNext());
+
+ assertThrows(NoSuchElementException.class, scanBeforeHashNext::next);
+ assertThrows(NoSuchElementException.class, scanAfterHasNext::next);
+ assertThrows(NoSuchElementException.class, scanWithoutHasNext::next);
+ }
+
+ @Test
+ void testScanContractAddRowsOnly() {
+ SortedIndexDefinition indexDefinition =
SchemaBuilders.sortedIndex("TEST_IDX")
+
.addIndexColumn(ColumnType.INT32.typeSpec().name()).asc().done()
+ .build();
+
+ SortedIndexStorage indexStorage = createIndexStorage(indexDefinition);
+
+ BinaryTupleRowSerializer serializer = new
BinaryTupleRowSerializer(indexStorage.indexDescriptor());
+
+ RowId rowId0 = new RowId(TEST_PARTITION, 0, 0);
+ RowId rowId1 = new RowId(TEST_PARTITION, 0, 1);
+ RowId rowId2 = new RowId(TEST_PARTITION, 1, 0);
+
+ Cursor<IndexRow> scan = indexStorage.scan(null, null, 0);
+
+ put(indexStorage, serializer.serializeRow(new Object[]{0}, rowId1));
+
+ IndexRow nextRow = scan.next();
+
+ assertEquals(0, serializer.deserializeColumns(nextRow)[0]);
+ assertEquals(rowId1, nextRow.rowId());
+
+ put(indexStorage, serializer.serializeRow(new Object[]{0}, rowId0));
+ put(indexStorage, serializer.serializeRow(new Object[]{0}, rowId2));
+
+ assertTrue(scan.hasNext());
+
+ nextRow = scan.next();
+
+ assertEquals(0, serializer.deserializeColumns(nextRow)[0]);
+ assertEquals(rowId2, nextRow.rowId());
+
+ put(indexStorage, serializer.serializeRow(new Object[]{1}, rowId0));
+ put(indexStorage, serializer.serializeRow(new Object[]{-1}, rowId0));
+
+ assertTrue(scan.hasNext());
+
+ nextRow = scan.next();
+
+ assertEquals(1, serializer.deserializeColumns(nextRow)[0]);
+ assertEquals(rowId0, nextRow.rowId());
+
+ assertFalse(scan.hasNext());
+ assertThrows(NoSuchElementException.class, scan::next);
+ }
+
+ @Test
+ void testScanContractForFinishCursor() {
+ SortedIndexDefinition indexDefinition =
SchemaBuilders.sortedIndex("TEST_IDX")
+
.addIndexColumn(ColumnType.INT32.typeSpec().name()).asc().done()
+ .build();
+
+ SortedIndexStorage indexStorage = createIndexStorage(indexDefinition);
+
+ BinaryTupleRowSerializer serializer = new
BinaryTupleRowSerializer(indexStorage.indexDescriptor());
+
+ Cursor<IndexRow> scan = indexStorage.scan(null, null, 0);
+
+ assertFalse(scan.hasNext());
+ assertThrows(NoSuchElementException.class, scan::next);
+
+ RowId rowId0 = new RowId(TEST_PARTITION, 0, 0);
+ RowId rowId1 = new RowId(TEST_PARTITION, 0, 1);
+
+ put(indexStorage, serializer.serializeRow(new Object[]{0}, rowId0));
+
+ assertTrue(scan.hasNext());
+
+ IndexRow nextRow = scan.next();
+
+ assertEquals(0, serializer.deserializeColumns(nextRow)[0]);
+ assertEquals(rowId0, nextRow.rowId());
+
+ assertFalse(scan.hasNext());
+ assertThrows(NoSuchElementException.class, scan::next);
+
+ put(indexStorage, serializer.serializeRow(new Object[]{0}, rowId0));
+
+ assertFalse(scan.hasNext());
+ assertThrows(NoSuchElementException.class, scan::next);
+
+ put(indexStorage, serializer.serializeRow(new Object[]{0}, rowId1));
+
+ assertTrue(scan.hasNext());
+
+ nextRow = scan.next();
+
+ assertEquals(0, serializer.deserializeColumns(nextRow)[0]);
+ assertEquals(rowId1, nextRow.rowId());
+
+ assertFalse(scan.hasNext());
+ assertThrows(NoSuchElementException.class, scan::next);
+
+ put(indexStorage, serializer.serializeRow(new Object[]{1}, rowId0));
+
+ assertTrue(scan.hasNext());
+
+ nextRow = scan.next();
+
+ assertEquals(1, serializer.deserializeColumns(nextRow)[0]);
+ assertEquals(rowId0, nextRow.rowId());
+
+ assertFalse(scan.hasNext());
+ assertThrows(NoSuchElementException.class, scan::next);
+
+ put(indexStorage, serializer.serializeRow(new Object[]{-1}, rowId0));
+
+ assertFalse(scan.hasNext());
+ assertThrows(NoSuchElementException.class, scan::next);
+ }
+
+ @Test
+ void testScanContractNextMethodOnly() {
+ SortedIndexDefinition indexDefinition =
SchemaBuilders.sortedIndex("TEST_IDX")
+
.addIndexColumn(ColumnType.INT32.typeSpec().name()).asc().done()
+ .build();
+
+ SortedIndexStorage indexStorage = createIndexStorage(indexDefinition);
+
+ BinaryTupleRowSerializer serializer = new
BinaryTupleRowSerializer(indexStorage.indexDescriptor());
+
+ RowId rowId0 = new RowId(TEST_PARTITION, 0, 0);
+ RowId rowId1 = new RowId(TEST_PARTITION, 0, 1);
+ RowId rowId2 = new RowId(TEST_PARTITION, 0, 1);
+
+ Cursor<IndexRow> scan = indexStorage.scan(null, null, 0);
+
+ put(indexStorage, serializer.serializeRow(new Object[]{0}, rowId0));
+
+ IndexRow nextRow = scan.next();
+
+ assertEquals(0, serializer.deserializeColumns(nextRow)[0]);
+ assertEquals(rowId0, nextRow.rowId());
+
+ put(indexStorage, serializer.serializeRow(new Object[]{0}, rowId1));
+
+ nextRow = scan.next();
+
+ assertEquals(0, serializer.deserializeColumns(nextRow)[0]);
+ assertEquals(rowId1, nextRow.rowId());
+
+ put(indexStorage, serializer.serializeRow(new Object[]{1}, rowId2));
+ put(indexStorage, serializer.serializeRow(new Object[]{-1}, rowId2));
+
+ nextRow = scan.next();
+
+ assertEquals(1, serializer.deserializeColumns(nextRow)[0]);
+ assertEquals(rowId2, nextRow.rowId());
+
+ assertThrows(NoSuchElementException.class, scan::next);
+ }
+
+ @Test
+ void testScanContractRemoveRowsOnly() {
+ SortedIndexDefinition indexDefinition =
SchemaBuilders.sortedIndex("TEST_IDX")
+
.addIndexColumn(ColumnType.INT32.typeSpec().name()).asc().done()
+ .build();
+
+ SortedIndexStorage indexStorage = createIndexStorage(indexDefinition);
+
+ BinaryTupleRowSerializer serializer = new
BinaryTupleRowSerializer(indexStorage.indexDescriptor());
+
+ RowId rowId0 = new RowId(TEST_PARTITION, 0, 0);
+ RowId rowId1 = new RowId(TEST_PARTITION, 0, 1);
+
+ put(indexStorage, serializer.serializeRow(new Object[]{0}, rowId0));
+ put(indexStorage, serializer.serializeRow(new Object[]{0}, rowId1));
+ put(indexStorage, serializer.serializeRow(new Object[]{1}, rowId0));
+ put(indexStorage, serializer.serializeRow(new Object[]{2}, rowId1));
+
+ Cursor<IndexRow> scan = indexStorage.scan(null, null, 0);
+
+ assertTrue(scan.hasNext());
+
+ remove(indexStorage, serializer.serializeRow(new Object[]{0}, rowId0));
+
+ IndexRow nextRow = scan.next();
+
+ assertEquals(0, serializer.deserializeColumns(nextRow)[0]);
+ assertEquals(rowId0, nextRow.rowId());
+
+ remove(indexStorage, serializer.serializeRow(new Object[]{0}, rowId1));
+
+ assertTrue(scan.hasNext());
+
+ nextRow = scan.next();
+
+ assertEquals(1, serializer.deserializeColumns(nextRow)[0]);
+ assertEquals(rowId0, nextRow.rowId());
+
+ remove(indexStorage, serializer.serializeRow(new Object[]{2}, rowId1));
+
+ assertFalse(scan.hasNext());
+ assertThrows(NoSuchElementException.class, scan::next);
+ }
+
Review Comment:
Fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
