sashapolo commented on code in PR #1397:
URL: https://github.com/apache/ignite-3/pull/1397#discussion_r1046023132
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##########
@@ -157,24 +159,29 @@ public MetaStorageManager(
this.storage = storage;
}
- private CompletableFuture<MetaStorageService>
initializeMetaStorage(Collection<String> metaStorageNodes) {
+ private CompletableFuture<MetaStorageService>
initializeMetaStorage(Set<String> metaStorageNodes) {
ClusterNode thisNode = clusterService.topologyService().localMember();
- if (metaStorageNodes.contains(thisNode.name())) {
+ PeersAndLearners configuration =
PeersAndLearners.fromConsistentIds(metaStorageNodes);
+
+ Peer localPeer = configuration.peer(thisNode.name());
+
+ if (localPeer != null) {
clusterService.topologyService().addEventHandler(new
TopologyEventHandler() {
@Override
public void onDisappeared(ClusterNode member) {
metaStorageSvcFut.thenAccept(svc ->
svc.closeCursors(member.id()));
}
});
- }
- storage.start();
+ storage.start();
+ }
try {
CompletableFuture<RaftGroupService> raftServiceFuture =
raftMgr.prepareRaftGroup(
INSTANCE,
- metaStorageNodes,
+ localPeer,
+ configuration,
() -> new MetaStorageListener(storage)
Review Comment:
I've created a ticket to remove this stuff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
