rpuch commented on code in PR #1405:
URL: https://github.com/apache/ignite-3/pull/1405#discussion_r1048104512
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/io/PartitionMetaIo.java:
##########
@@ -251,6 +253,7 @@ protected void printPage(long addr, int pageSize,
IgniteStringBuilder sb) {
sb.app("TablePartitionMeta [").nl()
.app("lastAppliedIndex=").app(getLastAppliedIndex(addr)).nl()
.app("lastAppliedTerm=").app(getLastAppliedTerm(addr)).nl()
+
.app("lastRaftGroupConfigFirstPageId=").app(getLastRaftGroupConfigFirstPageId(addr)).nl()
Review Comment:
Is this general style justified by something? If I'm not mistaken, then
using this 'commas and NLs' style would produce output like the following:
```
field1=val1
,field2=val2
,field3=val3
```
while 'just NLs' style will produce
```
field1=val1
field2=val2
field3=val3
```
To me, second result seems more readable (there is less noise caused by
commas, and this noise is not needed).
Why would we prefer first result to the second one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
