nizhikov commented on code in PR #10444:
URL: https://github.com/apache/ignite/pull/10444#discussion_r1052110369
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java:
##########
@@ -2118,7 +2141,7 @@ public SegmentArchiveResult archiveSegment(long absIdx)
throws StorageException
Files.move(dstTmpFile.toPath(), dstFile.toPath());
- if (walCdcDir != null)
+ if (walCdcDir != null && !cdcForceDisable.getOrDefault(false))
Review Comment:
Let's rewrite a bit and warn user every time we skip link creation.
```
if (walCdcDir != null) {
if (!cdcForceDisable.getOrDefault(false))
Files.createLink(walCdcDir.toPath().resolve(dstFile.getName()),
**dstFile.toPath());
else
log.warning("Creation of segment CDC link skiped. `cdc.disabled`
distributed property is false.");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
