denis-chudov commented on code in PR #1458:
URL: https://github.com/apache/ignite-3/pull/1458#discussion_r1053375514
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/SortedIndexLocker.java:
##########
@@ -95,39 +96,54 @@ public CompletableFuture<Void> locksForLookup(UUID txId,
BinaryRow tableRow) {
* @return A future representing a result.
Review Comment:
there is no description, what is the result. Same for `acquireLockNextKey`.
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##########
@@ -427,6 +428,55 @@ public void pureTableScan(Function<InternalTransaction,
CompletableFuture<Intege
assertEquals(ROW_IDS.size() + txOpFut.get(), scanAllRows(pub).size());
}
+ @Test
+ public void testTwiceScanInTransaction() throws Exception {
+ TableImpl table = getOrCreateTable();
+
+ InternalTable internalTable = table.internalTable();
+
+ KeyValueView kvView = table.keyValueView();
+
+ UUID soredIndexId = getSortedIndexId();
Review Comment:
typo: `sortedIndexId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
