korlov42 commented on code in PR #1454: URL: https://github.com/apache/ignite-3/pull/1454#discussion_r1055518877
########## modules/jdbc/src/main/java/org/apache/ignite/internal/ConnectionProperties.java: ########## @@ -15,7 +15,7 @@ * limitations under the License. */ -package org.apache.ignite.internal.jdbc; +package org.apache.ignite.internal; Review Comment: I would prefer to follow common patter `org.apache.ignite.internal.<name of the module>` which is `org.apache.ignite.internal.jdbc` for module `jdbc` ########## modules/jdbc/src/main/java/org/apache/ignite/jdbc/IgniteJdbcDriver.java: ########## @@ -17,7 +17,7 @@ package org.apache.ignite.jdbc; -import static org.apache.ignite.internal.jdbc.ConnectionPropertiesImpl.URL_PREFIX; +import static org.apache.ignite.internal.ConnectionPropertiesImpl.URL_PREFIX; Review Comment: could you please move `IgniteJdbcDriver` under 'internal.jdbc' package as well? The reason is the same: it's just another implementation of public interface `java.sql.Driver` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
