ivandasch commented on code in PR #10430:
URL: https://github.com/apache/ignite/pull/10430#discussion_r1055781368
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotFutureTask.java:
##########
@@ -943,12 +945,28 @@ protected void init() throws IOException {
if (!store.read(pageId, locBuf, true))
return;
- locBuf.flip();
+ locBuf.limit(locBuf.capacity());
+ locBuf.position(0);
writePage0(pageId, locBuf);
}
else {
// Direct buffer is needs to be written, associated
checkpoint not finished yet.
+ if
(PageIO.getCompressionType(GridUnsafe.bufferAddress(buf)) !=
CompressionProcessor.UNCOMPRESSED_PAGE) {
+ final ByteBuffer locBuf = locBuff.get();
+
+ assert locBuf.capacity() == store.getPageSize();
+
+ locBuf.clear();
+
+
GridUnsafe.copyOffheapOffheap(GridUnsafe.bufferAddress(buf),
GridUnsafe.bufferAddress(locBuf), buf.limit());
+
+ locBuf.limit(locBuf.capacity());
+ locBuf.position(0);
+
+ buf = locBuf;
+ }
Review Comment:
Sometimes the buf's length is less than the locBuf's length.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
