tkalkirill commented on code in PR #1464: URL: https://github.com/apache/ignite-3/pull/1464#discussion_r1056168633
########## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvPartitionStorageConcurrencyTest.java: ########## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.storage; + +import static org.apache.ignite.internal.testframework.IgniteTestUtils.runRace; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assumptions.assumeTrue; + +import org.apache.ignite.internal.hlc.HybridTimestamp; +import org.apache.ignite.internal.schema.BinaryRow; +import org.apache.ignite.internal.storage.impl.TestStorageEngine; +import org.jetbrains.annotations.Nullable; +import org.junit.jupiter.api.RepeatedTest; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.EnumSource; + +/** + * Test to check for race conditions in MV partition storage. + */ +public abstract class AbstractMvPartitionStorageConcurrencyTest extends BaseMvPartitionStorageTest { + /** To be used in a loop. {@link RepeatedTest} has a smaller failure rate due to recreating the storage every time. */ + private static final int REPEATS = 100; Review Comment: Maybe use **org.junit.jupiter.api.RepeatedTest**? ########## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/BinaryRowAndRowId.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.storage; + +import org.apache.ignite.internal.schema.BinaryRow; +import org.jetbrains.annotations.Nullable; + +/** + * Wrapper that holds both {@link BinaryRow} and {@link RowId}. {@link BinaryRow} is null for tombstones. + */ +public class BinaryRowAndRowId { + /** Binary row. */ + private final @Nullable BinaryRow binaryRow; + + /** Row id. */ + private final RowId rowId; + + /** + * Constructor. + * + * @param binaryRow Binary row. + * @param rowId Row id. + */ + public BinaryRowAndRowId(@Nullable BinaryRow binaryRow, RowId rowId) { + this.binaryRow = binaryRow; + this.rowId = rowId; + } + + public BinaryRow binaryRow() { Review Comment: ```suggestion public @Nullable BinaryRow binaryRow() { ``` ########## modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/IgniteTestUtils.java: ########## @@ -766,4 +771,57 @@ public static <T> T await(CompletionStage<T> stage, long timeout, TimeUnit unit) public static <T> T await(CompletionStage<T> stage) { return await(stage, TIMEOUT_SEC, TimeUnit.SECONDS); } + + /** + * {@link #runRace(long, RunnableX...)} with default timeout of 10 seconds. + */ + public static void runRace(RunnableX... actions) { + runRace(TimeUnit.SECONDS.toMillis(10), actions); + } + + /** + * Runs all actions, each in a separate thread, having a {@link CyclicBarrier} before calling {@link RunnableX#run()}. + * Waits for threads completion or fails with the assertion if timeout exceeded. + */ + public static void runRace(long timeoutMillis, RunnableX... actions) { + int length = actions.length; + + CyclicBarrier barrier = new CyclicBarrier(length); + + Set<Throwable> throwables = ConcurrentHashMap.newKeySet(); + + Thread[] threads = IntStream.range(0, length).mapToObj(i -> new Thread(() -> { + try { + barrier.await(); + + actions[i].run(); + } catch (Throwable e) { + throwables.add(e); + } + })).toArray(Thread[]::new); + + Stream.of(threads).forEach(Thread::start); + + try { + for (Thread thread : threads) { + thread.join(timeoutMillis); + } + } catch (InterruptedException e) { + for (Thread thread : threads) { + thread.interrupt(); + } + + fail("Race operations took too long."); + } + + if (!throwables.isEmpty()) { + AssertionError assertionError = new AssertionError("One or several threads have failed."); Review Comment: Nothing is said in the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
