tkalkirill commented on code in PR #1478:
URL: https://github.com/apache/ignite-3/pull/1478#discussion_r1058121380
##########
modules/rocksdb-common/src/main/java/org/apache/ignite/internal/rocksdb/BusyRocksIteratorAdapter.java:
##########
@@ -42,21 +42,30 @@ protected BusyRocksIteratorAdapter(IgniteSpinBusyLock
busyLock, RocksIterator it
/**
* Handles busy lock acquiring failure. This means that db has been
stopped and cursor can't proceed. Must throw an exception.
*/
- protected abstract void handleBusy();
+ protected abstract void handleBusyFail();
- private void handleBusy0() {
- handleBusy();
+ /**
+ * Handles busy lock acquiring success.
+ */
+ protected void handeBusySuccess() {
Review Comment:
This method is used here: `TxStateRocksDbStorage#scan`.
In method `scan` above, it is needed to check that we are not in a storage
rebalance state after getting a "busy" lock.
Alternatively, we can get rid of method `handeBusySuccess` and use own
cursor in `TxStateRocksDbStorage#scan' so as not to attach a crutch. I think
it's better to do so.
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
