ibessonov commented on code in PR #1478:
URL: https://github.com/apache/ignite-3/pull/1478#discussion_r1058384986
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/storage/state/rocksdb/TxStateRocksDbTableStorage.java:
##########
@@ -153,6 +153,8 @@ public TxStateStorage getOrCreateTxStateStorage(int
partitionId) {
partitionId,
this
);
+
+ storage.start();
Review Comment:
Technically, we should close the instance if there's an exception in
"start()", right? We may fix that in the future. This is the reason why I don't
like exceptions in constructors - they may easily produce leaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
