zstan commented on code in PR #1483: URL: https://github.com/apache/ignite-3/pull/1483#discussion_r1065377350
########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/DataProvider.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.framework; + +import java.util.Collection; + +/** + * Producer of the rows to use with {@link TestTable} in execution-related scenarios. + * + * <p>A data provider is supposed to be created for table on per-node basis. It's up + * to developer to keep data provider in sync with the schema of the table this data provider relates to. + * + * @param <T> A type of the produced elements. + * @see TestTable + */ +@FunctionalInterface +public interface DataProvider<T> extends Iterable<T> { + /** + * Creates data provider from given collection. + * + * @param collection Collection to use as source of data. + * @param <T> A type of the produced elements. + * @return A data provider instance backed by given collection. + */ + static <T> DataProvider<T> fromCollection(Collection<T> collection) { Review Comment: seems not used ########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/IgniteSchema.java: ########## @@ -38,11 +39,17 @@ public class IgniteSchema extends AbstractSchema { * Creates a Schema. * * @param schemaName Schema name. + * @param tableMap Schema name. Review Comment: fix java doc plz ########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestBuilders.java: ########## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.framework; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.function.Function; +import java.util.stream.Collectors; +import org.apache.calcite.schema.Table; +import org.apache.ignite.internal.schema.NativeType; +import org.apache.ignite.internal.sql.engine.schema.ColumnDescriptor; +import org.apache.ignite.internal.sql.engine.schema.ColumnDescriptorImpl; +import org.apache.ignite.internal.sql.engine.schema.DefaultValueStrategy; +import org.apache.ignite.internal.sql.engine.schema.IgniteSchema; +import org.apache.ignite.internal.sql.engine.schema.TableDescriptorImpl; +import org.apache.ignite.internal.sql.engine.trait.IgniteDistribution; + +/** + * A collection of builders to create test objects. + */ +public class TestBuilders { + /** Returns a builder of the test cluster object. */ + public static ClusterBuilder cluster() { + return new ClusterBuilderImpl(); + } + + /** Returns a builder of the test table object. */ + public static TableBuilder table() { + return new TableBuilderImpl(); + } + + /** + * A builder to created a test cluster object. + * + * @see TestCluster + */ + public interface ClusterBuilder { + /** + * Sets desired names for the cluster nodes. + * + * @param nodeNames An array of node names to create cluster from. + * @return {@code this} for chaining. + */ + ClusterBuilder nodes(String... nodeNames); + + /** + * Creates a table builder to add to the cluster. + * + * @return An instance of table builder. + */ + ClusterTableBuilder addTable(); + + /** + * Builds the cluster object. + * + * @return Created cluster object. + */ + TestCluster build(); + } + + /** + * A builder to created a test table object. + * + * @see TestTable + */ + public interface TableBuilder extends TableBuilderBase<TableBuilder> { + /** + * Builds a table. + * + * @return Created table object. + */ + public TestTable build(); + } + + /** + * A builder to created a test table as nested object of the cluster. + * + * @see TestTable + * @see TestCluster + */ + public interface ClusterTableBuilder extends TableBuilderBase<ClusterTableBuilder>, NestedBuilder<ClusterBuilder> { + } + + private static class ClusterBuilderImpl implements ClusterBuilder { + private final List<TestTable> tables = new ArrayList<>(); + private List<String> nodeNames; + + @Override + public ClusterBuilder nodes(String... nodeNames) { + this.nodeNames = List.of(nodeNames); + + return this; + } + + @Override + public ClusterTableBuilder addTable() { + return new ClusterTableBuilderImpl(this); + } + + @Override + public TestCluster build() { + var clusterService = new TestClusterService(nodeNames); + + Map<String, Table> tableMap = tables.stream() + .collect(Collectors.toMap(TestTable::name, Function.identity())); + + var schemaManager = new PredefinedSchemaManager(new IgniteSchema("PUBLIC", tableMap, null)); + + Map<String, TestNode> nodes = nodeNames.stream() + .map(name -> new TestNode(name, clusterService.spawnForNode(name), schemaManager)) + .collect(Collectors.toMap(TestNode::name, Function.identity())); + + return new TestCluster(nodes); + } + + } + + private static class TableBuilderImpl extends AbstractTableBuilderImpl<TableBuilder> implements TableBuilder { + /** {@inheritDoc} */ + @Override + public TestTable build() { + return new TestTable( + new TableDescriptorImpl(columns, distribution), name, dataProviders, size + ); + } + + /** {@inheritDoc} */ + @Override + protected TableBuilder self() { + return this; + } + } + + private static class ClusterTableBuilderImpl extends AbstractTableBuilderImpl<ClusterTableBuilder> implements ClusterTableBuilder { + private final ClusterBuilderImpl parent; + + private ClusterTableBuilderImpl(ClusterBuilderImpl parent) { + this.parent = parent; + } + + /** {@inheritDoc} */ + @Override + protected ClusterTableBuilder self() { + return this; + } + + /** {@inheritDoc} */ + @Override + public ClusterBuilder end() { + parent.tables.add(new TestTable( + new TableDescriptorImpl(columns, distribution), name, dataProviders, size + )); + + return parent; + } + } + + private abstract static class AbstractTableBuilderImpl<ChildT> implements TableBuilderBase<ChildT> { + protected final List<ColumnDescriptor> columns = new ArrayList<>(); + protected final Map<String, DataProvider<?>> dataProviders = new HashMap<>(); + + protected String name; + protected IgniteDistribution distribution; + protected int size = 100_000; + + protected abstract ChildT self(); + + /** {@inheritDoc} */ + @Override + public ChildT name(String name) { + this.name = name; + + return self(); + } + + /** {@inheritDoc} */ + @Override + public ChildT distribution(IgniteDistribution distribution) { + this.distribution = distribution; + + return self(); + } + + /** {@inheritDoc} */ + @Override + public ChildT addColumn(String name, NativeType type) { + columns.add(new ColumnDescriptorImpl( + name, false, true, columns.size(), columns.size(), type, DefaultValueStrategy.DEFAULT_NULL, null + )); + + return self(); + } + + /** {@inheritDoc} */ + @Override + public ChildT addDataProvider(String targetNode, DataProvider<?> dataProvider) { Review Comment: so, we can have different provider per node? is it useful ? probably we need additional method without _targetNode_ used for all nodes by default ? ########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestBuilders.java: ########## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.framework; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.function.Function; +import java.util.stream.Collectors; +import org.apache.calcite.schema.Table; +import org.apache.ignite.internal.schema.NativeType; +import org.apache.ignite.internal.sql.engine.schema.ColumnDescriptor; +import org.apache.ignite.internal.sql.engine.schema.ColumnDescriptorImpl; +import org.apache.ignite.internal.sql.engine.schema.DefaultValueStrategy; +import org.apache.ignite.internal.sql.engine.schema.IgniteSchema; +import org.apache.ignite.internal.sql.engine.schema.TableDescriptorImpl; +import org.apache.ignite.internal.sql.engine.trait.IgniteDistribution; + +/** + * A collection of builders to create test objects. + */ +public class TestBuilders { + /** Returns a builder of the test cluster object. */ + public static ClusterBuilder cluster() { + return new ClusterBuilderImpl(); + } + + /** Returns a builder of the test table object. */ + public static TableBuilder table() { + return new TableBuilderImpl(); + } + + /** + * A builder to created a test cluster object. Review Comment: ```suggestion * A builder to create a test cluster object. ``` ########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestTable.java: ########## @@ -0,0 +1,305 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.framework; + +import java.lang.reflect.Proxy; +import java.util.BitSet; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.UUID; +import org.apache.calcite.config.CalciteConnectionConfig; +import org.apache.calcite.plan.RelOptCluster; +import org.apache.calcite.plan.RelOptTable; +import org.apache.calcite.rel.RelCollation; +import org.apache.calcite.rel.RelDistribution; +import org.apache.calcite.rel.RelReferentialConstraint; +import org.apache.calcite.rel.core.TableModify.Operation; +import org.apache.calcite.rel.hint.RelHint; +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rel.type.RelDataTypeFactory; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.schema.Schema; +import org.apache.calcite.schema.Statistic; +import org.apache.calcite.sql.SqlCall; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.util.ImmutableBitSet; +import org.apache.ignite.internal.schema.BinaryRow; +import org.apache.ignite.internal.sql.engine.exec.ExecutionContext; +import org.apache.ignite.internal.sql.engine.exec.RowHandler.RowFactory; +import org.apache.ignite.internal.sql.engine.metadata.ColocationGroup; +import org.apache.ignite.internal.sql.engine.prepare.MappingQueryContext; +import org.apache.ignite.internal.sql.engine.rel.logical.IgniteLogicalIndexScan; +import org.apache.ignite.internal.sql.engine.rel.logical.IgniteLogicalTableScan; +import org.apache.ignite.internal.sql.engine.schema.IgniteIndex; +import org.apache.ignite.internal.sql.engine.schema.InternalIgniteTable; +import org.apache.ignite.internal.sql.engine.schema.ModifyRow; +import org.apache.ignite.internal.sql.engine.schema.TableDescriptor; +import org.apache.ignite.internal.sql.engine.trait.IgniteDistribution; +import org.apache.ignite.internal.sql.engine.type.IgniteTypeFactory; +import org.apache.ignite.internal.table.InternalTable; +import org.jetbrains.annotations.Nullable; + +/** + * A test table which implements all necessary methods for optimizer in order to being use + * for query preparation, as well as provide access to the data for use this table + * in execution-related scenarios. + */ +public class TestTable implements InternalIgniteTable { + private static final AssertionError DATA_PROVIDER_NOT_CONFIGURED_EXCEPTION = Review Comment: All that end user can see is just this error creation i don`t think it`s right ? `java.lang.AssertionError: DataProvider not configured at org.apache.ignite.internal.sql.engine.framework.TestTable.<clinit>(TestTable.java:65) at org.apache.ignite.internal.sql.engine.framework.TestBuilders$ClusterTableBuilderImpl.end(TestBuilders.java:167)` ########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/benchmarks/SqlBenchmark.java: ########## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.benchmarks; + +import static org.apache.ignite.internal.testframework.IgniteTestUtils.await; + +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; +import java.util.UUID; +import java.util.concurrent.TimeUnit; +import org.apache.ignite.internal.schema.NativeTypes; +import org.apache.ignite.internal.sql.engine.framework.DataProvider; +import org.apache.ignite.internal.sql.engine.framework.TestBuilders; +import org.apache.ignite.internal.sql.engine.framework.TestCluster; +import org.apache.ignite.internal.sql.engine.framework.TestNode; +import org.apache.ignite.internal.sql.engine.prepare.QueryPlan; +import org.apache.ignite.internal.sql.engine.trait.IgniteDistributions; +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.BenchmarkMode; +import org.openjdk.jmh.annotations.Fork; +import org.openjdk.jmh.annotations.Measurement; +import org.openjdk.jmh.annotations.Mode; +import org.openjdk.jmh.annotations.OutputTimeUnit; +import org.openjdk.jmh.annotations.Scope; +import org.openjdk.jmh.annotations.Setup; +import org.openjdk.jmh.annotations.State; +import org.openjdk.jmh.annotations.TearDown; +import org.openjdk.jmh.annotations.Warmup; +import org.openjdk.jmh.infra.Blackhole; +import org.openjdk.jmh.runner.Runner; +import org.openjdk.jmh.runner.options.Options; +import org.openjdk.jmh.runner.options.OptionsBuilder; + +/** + * A micro-benchmark of sql execution. + */ +@Warmup(iterations = 20, time = 1, timeUnit = TimeUnit.SECONDS) +@Measurement(iterations = 20, time = 1, timeUnit = TimeUnit.SECONDS) +@BenchmarkMode(Mode.Throughput) +@OutputTimeUnit(TimeUnit.SECONDS) +@Fork(1) +@State(Scope.Benchmark) +public class SqlBenchmark { + private final DataProvider<Object[]> dataProvider = new SameRowDataProvider( + new Object[] {42, UUID.randomUUID().toString()}, 333 + ); + + // @formatter:off + private final TestCluster cluster = TestBuilders.cluster() + .nodes("N1", "N2", "N3") + .addTable() + .name("T1") + .distribution(IgniteDistributions.hash(List.of(0))) + .addColumn("ID", NativeTypes.INT32) + .addColumn("VAL", NativeTypes.stringOf(64)) + .addDataProvider("N1", dataProvider) Review Comment: if comment all **dataProveder**`s - tests will hang forever ########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestClusterService.java: ########## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.framework; + +import java.util.Collection; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.function.Function; +import java.util.stream.Collectors; +import org.apache.ignite.network.AbstractMessagingService; +import org.apache.ignite.network.AbstractTopologyService; +import org.apache.ignite.network.ClusterLocalConfiguration; +import org.apache.ignite.network.ClusterNode; +import org.apache.ignite.network.ClusterService; +import org.apache.ignite.network.MessagingService; +import org.apache.ignite.network.NetworkAddress; +import org.apache.ignite.network.NetworkMessage; +import org.apache.ignite.network.NetworkMessageHandler; +import org.apache.ignite.network.NodeMetadata; +import org.apache.ignite.network.TopologyService; +import org.jetbrains.annotations.Nullable; + +/** + * Dummy cluster service object which helps to created connect Review Comment: ```suggestion * Dummy cluster service object which helps to create connected ``` ########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestBuilders.java: ########## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.framework; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.function.Function; +import java.util.stream.Collectors; +import org.apache.calcite.schema.Table; +import org.apache.ignite.internal.schema.NativeType; +import org.apache.ignite.internal.sql.engine.schema.ColumnDescriptor; +import org.apache.ignite.internal.sql.engine.schema.ColumnDescriptorImpl; +import org.apache.ignite.internal.sql.engine.schema.DefaultValueStrategy; +import org.apache.ignite.internal.sql.engine.schema.IgniteSchema; +import org.apache.ignite.internal.sql.engine.schema.TableDescriptorImpl; +import org.apache.ignite.internal.sql.engine.trait.IgniteDistribution; + +/** + * A collection of builders to create test objects. + */ +public class TestBuilders { + /** Returns a builder of the test cluster object. */ + public static ClusterBuilder cluster() { + return new ClusterBuilderImpl(); + } + + /** Returns a builder of the test table object. */ + public static TableBuilder table() { + return new TableBuilderImpl(); + } + + /** + * A builder to created a test cluster object. + * + * @see TestCluster + */ + public interface ClusterBuilder { + /** + * Sets desired names for the cluster nodes. + * + * @param nodeNames An array of node names to create cluster from. + * @return {@code this} for chaining. + */ + ClusterBuilder nodes(String... nodeNames); + + /** + * Creates a table builder to add to the cluster. + * + * @return An instance of table builder. + */ + ClusterTableBuilder addTable(); + + /** + * Builds the cluster object. + * + * @return Created cluster object. + */ + TestCluster build(); + } + + /** + * A builder to created a test table object. Review Comment: ```suggestion * A builder to create a test table object. ``` ########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestBuilders.java: ########## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.framework; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.function.Function; +import java.util.stream.Collectors; +import org.apache.calcite.schema.Table; +import org.apache.ignite.internal.schema.NativeType; +import org.apache.ignite.internal.sql.engine.schema.ColumnDescriptor; +import org.apache.ignite.internal.sql.engine.schema.ColumnDescriptorImpl; +import org.apache.ignite.internal.sql.engine.schema.DefaultValueStrategy; +import org.apache.ignite.internal.sql.engine.schema.IgniteSchema; +import org.apache.ignite.internal.sql.engine.schema.TableDescriptorImpl; +import org.apache.ignite.internal.sql.engine.trait.IgniteDistribution; + +/** + * A collection of builders to create test objects. + */ +public class TestBuilders { + /** Returns a builder of the test cluster object. */ + public static ClusterBuilder cluster() { + return new ClusterBuilderImpl(); + } + + /** Returns a builder of the test table object. */ + public static TableBuilder table() { + return new TableBuilderImpl(); + } + + /** + * A builder to created a test cluster object. + * + * @see TestCluster + */ + public interface ClusterBuilder { + /** + * Sets desired names for the cluster nodes. + * + * @param nodeNames An array of node names to create cluster from. + * @return {@code this} for chaining. + */ + ClusterBuilder nodes(String... nodeNames); + + /** + * Creates a table builder to add to the cluster. + * + * @return An instance of table builder. + */ + ClusterTableBuilder addTable(); + + /** + * Builds the cluster object. + * + * @return Created cluster object. + */ + TestCluster build(); + } + + /** + * A builder to created a test table object. + * + * @see TestTable + */ + public interface TableBuilder extends TableBuilderBase<TableBuilder> { + /** + * Builds a table. + * + * @return Created table object. + */ + public TestTable build(); + } + + /** + * A builder to created a test table as nested object of the cluster. Review Comment: ```suggestion * A builder to create a test table as nested object of the cluster. ``` ########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestBuilders.java: ########## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.framework; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.function.Function; +import java.util.stream.Collectors; +import org.apache.calcite.schema.Table; +import org.apache.ignite.internal.schema.NativeType; +import org.apache.ignite.internal.sql.engine.schema.ColumnDescriptor; +import org.apache.ignite.internal.sql.engine.schema.ColumnDescriptorImpl; +import org.apache.ignite.internal.sql.engine.schema.DefaultValueStrategy; +import org.apache.ignite.internal.sql.engine.schema.IgniteSchema; +import org.apache.ignite.internal.sql.engine.schema.TableDescriptorImpl; +import org.apache.ignite.internal.sql.engine.trait.IgniteDistribution; + +/** + * A collection of builders to create test objects. + */ +public class TestBuilders { + /** Returns a builder of the test cluster object. */ + public static ClusterBuilder cluster() { + return new ClusterBuilderImpl(); + } + + /** Returns a builder of the test table object. */ + public static TableBuilder table() { + return new TableBuilderImpl(); + } + + /** + * A builder to created a test cluster object. + * + * @see TestCluster + */ + public interface ClusterBuilder { + /** + * Sets desired names for the cluster nodes. + * + * @param nodeNames An array of node names to create cluster from. + * @return {@code this} for chaining. + */ + ClusterBuilder nodes(String... nodeNames); + + /** + * Creates a table builder to add to the cluster. + * + * @return An instance of table builder. + */ + ClusterTableBuilder addTable(); + + /** + * Builds the cluster object. + * + * @return Created cluster object. + */ + TestCluster build(); + } + + /** + * A builder to created a test table object. + * + * @see TestTable + */ + public interface TableBuilder extends TableBuilderBase<TableBuilder> { + /** + * Builds a table. + * + * @return Created table object. + */ + public TestTable build(); + } + + /** + * A builder to created a test table as nested object of the cluster. + * + * @see TestTable + * @see TestCluster + */ + public interface ClusterTableBuilder extends TableBuilderBase<ClusterTableBuilder>, NestedBuilder<ClusterBuilder> { + } + + private static class ClusterBuilderImpl implements ClusterBuilder { + private final List<TestTable> tables = new ArrayList<>(); + private List<String> nodeNames; + + @Override + public ClusterBuilder nodes(String... nodeNames) { + this.nodeNames = List.of(nodeNames); + + return this; + } + + @Override + public ClusterTableBuilder addTable() { + return new ClusterTableBuilderImpl(this); + } + + @Override + public TestCluster build() { + var clusterService = new TestClusterService(nodeNames); + + Map<String, Table> tableMap = tables.stream() + .collect(Collectors.toMap(TestTable::name, Function.identity())); + + var schemaManager = new PredefinedSchemaManager(new IgniteSchema("PUBLIC", tableMap, null)); + + Map<String, TestNode> nodes = nodeNames.stream() + .map(name -> new TestNode(name, clusterService.spawnForNode(name), schemaManager)) + .collect(Collectors.toMap(TestNode::name, Function.identity())); + + return new TestCluster(nodes); + } + + } + + private static class TableBuilderImpl extends AbstractTableBuilderImpl<TableBuilder> implements TableBuilder { + /** {@inheritDoc} */ + @Override + public TestTable build() { + return new TestTable( + new TableDescriptorImpl(columns, distribution), name, dataProviders, size + ); + } + + /** {@inheritDoc} */ + @Override + protected TableBuilder self() { + return this; + } + } + + private static class ClusterTableBuilderImpl extends AbstractTableBuilderImpl<ClusterTableBuilder> implements ClusterTableBuilder { + private final ClusterBuilderImpl parent; + + private ClusterTableBuilderImpl(ClusterBuilderImpl parent) { + this.parent = parent; + } + + /** {@inheritDoc} */ + @Override + protected ClusterTableBuilder self() { + return this; + } + + /** {@inheritDoc} */ + @Override + public ClusterBuilder end() { + parent.tables.add(new TestTable( + new TableDescriptorImpl(columns, distribution), name, dataProviders, size + )); + + return parent; + } + } + + private abstract static class AbstractTableBuilderImpl<ChildT> implements TableBuilderBase<ChildT> { + protected final List<ColumnDescriptor> columns = new ArrayList<>(); + protected final Map<String, DataProvider<?>> dataProviders = new HashMap<>(); + + protected String name; + protected IgniteDistribution distribution; + protected int size = 100_000; + + protected abstract ChildT self(); + + /** {@inheritDoc} */ + @Override + public ChildT name(String name) { + this.name = name; + + return self(); + } + + /** {@inheritDoc} */ + @Override + public ChildT distribution(IgniteDistribution distribution) { + this.distribution = distribution; + + return self(); + } + + /** {@inheritDoc} */ + @Override + public ChildT addColumn(String name, NativeType type) { + columns.add(new ColumnDescriptorImpl( + name, false, true, columns.size(), columns.size(), type, DefaultValueStrategy.DEFAULT_NULL, null + )); + + return self(); + } + + /** {@inheritDoc} */ + @Override + public ChildT addDataProvider(String targetNode, DataProvider<?> dataProvider) { + this.dataProviders.put(targetNode, dataProvider); + + return self(); + } + + /** {@inheritDoc} */ + @Override + public ChildT size(int size) { + this.size = size; + + return self(); + } + } + + /** + * Base interface describing the complete set of table-related fields. + * + * <p>The sole purpose of this interface is to keep in sync both variants of table's builders. + * + * @param <ChildT> An actual type of builder that should be exposed to the user. + * @see ClusterTableBuilder + * @see TableBuilder + */ + private interface TableBuilderBase<ChildT> { + /** Sets the name of the table. */ + ChildT name(String name); + + /** Sets the distribution of the table. */ + ChildT distribution(IgniteDistribution distribution); + + /** Adds a column to the table. */ + ChildT addColumn(String name, NativeType type); + + /** + * Adds a data provider for the given node to the table. + * TODO Review Comment: forgotten TODO. ########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestBuilders.java: ########## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.framework; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.function.Function; +import java.util.stream.Collectors; +import org.apache.calcite.schema.Table; +import org.apache.ignite.internal.schema.NativeType; +import org.apache.ignite.internal.sql.engine.schema.ColumnDescriptor; +import org.apache.ignite.internal.sql.engine.schema.ColumnDescriptorImpl; +import org.apache.ignite.internal.sql.engine.schema.DefaultValueStrategy; +import org.apache.ignite.internal.sql.engine.schema.IgniteSchema; +import org.apache.ignite.internal.sql.engine.schema.TableDescriptorImpl; +import org.apache.ignite.internal.sql.engine.trait.IgniteDistribution; + +/** + * A collection of builders to create test objects. + */ +public class TestBuilders { + /** Returns a builder of the test cluster object. */ + public static ClusterBuilder cluster() { + return new ClusterBuilderImpl(); + } + + /** Returns a builder of the test table object. */ + public static TableBuilder table() { + return new TableBuilderImpl(); + } + + /** + * A builder to created a test cluster object. + * + * @see TestCluster + */ + public interface ClusterBuilder { + /** + * Sets desired names for the cluster nodes. + * + * @param nodeNames An array of node names to create cluster from. + * @return {@code this} for chaining. + */ + ClusterBuilder nodes(String... nodeNames); + + /** + * Creates a table builder to add to the cluster. + * + * @return An instance of table builder. + */ + ClusterTableBuilder addTable(); + + /** + * Builds the cluster object. + * + * @return Created cluster object. + */ + TestCluster build(); + } + + /** + * A builder to created a test table object. + * + * @see TestTable + */ + public interface TableBuilder extends TableBuilderBase<TableBuilder> { + /** + * Builds a table. + * + * @return Created table object. + */ + public TestTable build(); + } + + /** + * A builder to created a test table as nested object of the cluster. + * + * @see TestTable + * @see TestCluster + */ + public interface ClusterTableBuilder extends TableBuilderBase<ClusterTableBuilder>, NestedBuilder<ClusterBuilder> { + } + + private static class ClusterBuilderImpl implements ClusterBuilder { + private final List<TestTable> tables = new ArrayList<>(); + private List<String> nodeNames; + + @Override + public ClusterBuilder nodes(String... nodeNames) { + this.nodeNames = List.of(nodeNames); + + return this; + } + Review Comment: /** {@inheritDoc} */ me and near ########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestClusterService.java: ########## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.framework; + +import java.util.Collection; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.function.Function; +import java.util.stream.Collectors; +import org.apache.ignite.network.AbstractMessagingService; +import org.apache.ignite.network.AbstractTopologyService; +import org.apache.ignite.network.ClusterLocalConfiguration; +import org.apache.ignite.network.ClusterNode; +import org.apache.ignite.network.ClusterService; +import org.apache.ignite.network.MessagingService; +import org.apache.ignite.network.NetworkAddress; +import org.apache.ignite.network.NetworkMessage; +import org.apache.ignite.network.NetworkMessageHandler; +import org.apache.ignite.network.NodeMetadata; +import org.apache.ignite.network.TopologyService; +import org.jetbrains.annotations.Nullable; + +/** + * Dummy cluster service object which helps to created connect Review Comment: Additionally i suppose that too frequent "dummy" word usage is excessive, whole ignite code is hard to understand ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
