valepakh commented on code in PR #1479:
URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1069449286
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -1931,19 +1944,19 @@ private HybridTimestampMessage
hybridTimestamp(HybridTimestamp tmstmp) {
*
* @param tablePartId {@link TablePartitionId} object to construct {@link
UpdateCommand} object with.
* @param rowUuid Row UUID.
- * @param rowBuf {@link ByteBuffer} representation of {@link BinaryRow}.
+ * @param row {@link BinaryRow}.
* @param txId Transaction ID.
* @return Constructed {@link UpdateCommand} object.
*/
- private UpdateCommand updateCommand(TablePartitionId tablePartId, UUID
rowUuid, ByteBuffer rowBuf, UUID txId) {
+ private UpdateCommand updateCommand(TablePartitionId tablePartId, UUID
rowUuid, TableRow row, UUID txId) {
Review Comment:
Mainly to reduce clutter at the call site, but probably it would be better
if the update and updateAll singatures would be similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
