lowka commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1071140488
########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/LeastRestrictiveTypesTest.java: ########## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.prepare; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.stream.Stream; +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.sql.type.SqlTypeName; +import org.apache.ignite.internal.sql.engine.type.IgniteTypeFactory; +import org.jetbrains.annotations.Nullable; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +/** + * Tests the behaviour of {@link IgniteTypeFactory#leastRestrictive(List)}. + */ +public class LeastRestrictiveTypesTest { + + private static final IgniteTypeFactory TYPE_FACTORY = new IgniteTypeFactory(); + + private static final RelDataType TINYINT = TYPE_FACTORY.createSqlType(SqlTypeName.TINYINT); + + private static final RelDataType SMALLINT = TYPE_FACTORY.createSqlType(SqlTypeName.SMALLINT); + + private static final RelDataType INTEGER = TYPE_FACTORY.createSqlType(SqlTypeName.INTEGER); + + private static final RelDataType FLOAT = TYPE_FACTORY.createSqlType(SqlTypeName.FLOAT); + + private static final RelDataType DOUBLE = TYPE_FACTORY.createSqlType(SqlTypeName.DOUBLE); + + private static final RelDataType REAL = TYPE_FACTORY.createSqlType(SqlTypeName.REAL); + + private static final RelDataType BIGINT = TYPE_FACTORY.createSqlType(SqlTypeName.BIGINT); + + private static final RelDataType DECIMAL = TYPE_FACTORY.createSqlType(SqlTypeName.DECIMAL, 1000, 10); + + @ParameterizedTest + @MethodSource("tinyIntTests") + public void testTinyInt(RelDataType t1, RelDataType t2, LeastRestrictiveType leastRestrictiveType) { + expectLeastRestrictiveType(t1, t2, leastRestrictiveType); + expectLeastRestrictiveType(t2, t1, leastRestrictiveType); + } + + private static Stream<Arguments> tinyIntTests() { + List<Arguments> tests = new ArrayList<>(); + + tests.add(Arguments.arguments(TINYINT, TINYINT, new LeastRestrictiveType(TINYINT))); + tests.add(Arguments.arguments(TINYINT, SMALLINT, new LeastRestrictiveType(SMALLINT))); + tests.add(Arguments.arguments(TINYINT, INTEGER, new LeastRestrictiveType(INTEGER))); + tests.add(Arguments.arguments(TINYINT, FLOAT, new LeastRestrictiveType(FLOAT))); + tests.add(Arguments.arguments(TINYINT, REAL, new LeastRestrictiveType(REAL))); + tests.add(Arguments.arguments(TINYINT, DOUBLE, new LeastRestrictiveType(DOUBLE))); + tests.add(Arguments.arguments(TINYINT, DECIMAL, new LeastRestrictiveType(DECIMAL))); + tests.add(Arguments.arguments(TINYINT, BIGINT, new LeastRestrictiveType(BIGINT))); + + return tests.stream(); + } + + @ParameterizedTest + @MethodSource("smallIntTests") + public void testSmallInt(RelDataType t1, RelDataType t2, LeastRestrictiveType leastRestrictiveType) { + expectLeastRestrictiveType(t1, t2, leastRestrictiveType); + expectLeastRestrictiveType(t2, t1, leastRestrictiveType); + } + + private static Stream<Arguments> smallIntTests() { + List<Arguments> tests = new ArrayList<>(); + + tests.add(Arguments.arguments(SMALLINT, TINYINT, new LeastRestrictiveType(SMALLINT))); + tests.add(Arguments.arguments(SMALLINT, SMALLINT, new LeastRestrictiveType(SMALLINT))); + tests.add(Arguments.arguments(SMALLINT, INTEGER, new LeastRestrictiveType(INTEGER))); + tests.add(Arguments.arguments(SMALLINT, FLOAT, new LeastRestrictiveType(FLOAT))); + tests.add(Arguments.arguments(SMALLINT, REAL, new LeastRestrictiveType(REAL))); + tests.add(Arguments.arguments(SMALLINT, DOUBLE, new LeastRestrictiveType(DOUBLE))); + tests.add(Arguments.arguments(SMALLINT, DECIMAL, new LeastRestrictiveType(DECIMAL))); + tests.add(Arguments.arguments(SMALLINT, BIGINT, new LeastRestrictiveType(BIGINT))); + + return tests.stream(); + } + + @ParameterizedTest + @MethodSource("intTests") + public void testInteger(RelDataType t1, RelDataType t2, LeastRestrictiveType leastRestrictiveType) { + expectLeastRestrictiveType(t1, t2, leastRestrictiveType); + expectLeastRestrictiveType(t2, t1, leastRestrictiveType); + } + + private static Stream<Arguments> intTests() { + List<Arguments> tests = new ArrayList<>(); + + tests.add(Arguments.arguments(INTEGER, TINYINT, new LeastRestrictiveType(INTEGER))); + tests.add(Arguments.arguments(INTEGER, SMALLINT, new LeastRestrictiveType(INTEGER))); + tests.add(Arguments.arguments(INTEGER, INTEGER, new LeastRestrictiveType(INTEGER))); + tests.add(Arguments.arguments(INTEGER, FLOAT, new LeastRestrictiveType(FLOAT))); + tests.add(Arguments.arguments(INTEGER, REAL, new LeastRestrictiveType(REAL))); + tests.add(Arguments.arguments(INTEGER, DOUBLE, new LeastRestrictiveType(DOUBLE))); + tests.add(Arguments.arguments(INTEGER, DECIMAL, new LeastRestrictiveType(DECIMAL))); + tests.add(Arguments.arguments(INTEGER, BIGINT, new LeastRestrictiveType(BIGINT))); + + return tests.stream(); + } + + @ParameterizedTest + @MethodSource("floatTests") + public void testFloat(RelDataType t1, RelDataType t2, LeastRestrictiveType leastRestrictiveType) { + if (t1.equals(FLOAT) && t2.equals(DOUBLE)) { + // Something is not right here. + expectLeastRestrictiveType(t1, t2, new LeastRestrictiveType(FLOAT)); + expectLeastRestrictiveType(t2, t1, new LeastRestrictiveType(DOUBLE)); + } else { + expectLeastRestrictiveType(t1, t2, leastRestrictiveType); + expectLeastRestrictiveType(t2, t1, leastRestrictiveType); + } + } + + private static Stream<Arguments> floatTests() { + List<Arguments> tests = new ArrayList<>(); + + tests.add(Arguments.arguments(FLOAT, TINYINT, new LeastRestrictiveType(FLOAT))); + tests.add(Arguments.arguments(FLOAT, SMALLINT, new LeastRestrictiveType(FLOAT))); + tests.add(Arguments.arguments(FLOAT, INTEGER, new LeastRestrictiveType(FLOAT))); + tests.add(Arguments.arguments(FLOAT, FLOAT, new LeastRestrictiveType(FLOAT))); + tests.add(Arguments.arguments(FLOAT, REAL, new LeastRestrictiveType(FLOAT))); + // See testFloat + tests.add(Arguments.arguments(FLOAT, DOUBLE, new LeastRestrictiveType(DOUBLE))); + tests.add(Arguments.arguments(FLOAT, DECIMAL, new LeastRestrictiveType(DOUBLE))); + tests.add(Arguments.arguments(FLOAT, BIGINT, new LeastRestrictiveType(FLOAT))); + + return tests.stream(); + } + + @ParameterizedTest + @MethodSource("doubleTests") + public void testDouble(RelDataType t1, RelDataType t2, LeastRestrictiveType leastRestrictiveType) { + expectLeastRestrictiveType(t1, t2, leastRestrictiveType); + expectLeastRestrictiveType(t2, t1, leastRestrictiveType); + } + + private static Stream<Arguments> doubleTests() { + List<Arguments> tests = new ArrayList<>(); + + tests.add(Arguments.arguments(DOUBLE, TINYINT, new LeastRestrictiveType(DOUBLE))); + tests.add(Arguments.arguments(DOUBLE, SMALLINT, new LeastRestrictiveType(DOUBLE))); + tests.add(Arguments.arguments(DOUBLE, INTEGER, new LeastRestrictiveType(DOUBLE))); + //See testFloat + //tests.add(Arguments.arguments(DOUBLE, FLOAT, new LeastRestrictiveType(FLOAT))); + tests.add(Arguments.arguments(DOUBLE, REAL, new LeastRestrictiveType(DOUBLE))); + tests.add(Arguments.arguments(DOUBLE, DOUBLE, new LeastRestrictiveType(DOUBLE))); + tests.add(Arguments.arguments(DOUBLE, DECIMAL, new LeastRestrictiveType(DOUBLE))); + tests.add(Arguments.arguments(DOUBLE, BIGINT, new LeastRestrictiveType(DOUBLE))); + + return tests.stream(); + } + + @ParameterizedTest + @MethodSource("decimalTests") + public void testDecimal(RelDataType t1, RelDataType t2, LeastRestrictiveType leastRestrictiveType) { + if (t1.equals(DOUBLE) && t2.equals(DECIMAL)) { + expectLeastRestrictiveType(t1, t2, new LeastRestrictiveType(DOUBLE)); Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
