ademakov commented on code in PR #1479:
URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1073371038
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java:
##########
@@ -151,7 +151,7 @@ public interface MvPartitionStorage extends
ManuallyCloseable {
* @throws TxIdMismatchException If there's another pending update
associated with different transaction id.
* @throws StorageException If failed to write data to the storage.
*/
- @Nullable BinaryRow addWrite(RowId rowId, @Nullable BinaryRow row, UUID
txId, UUID commitTableId, int commitPartitionId)
+ @Nullable TableRow addWrite(RowId rowId, @Nullable TableRow row, UUID
txId, UUID commitTableId, int commitPartitionId)
Review Comment:
Columnar storage does not store schema version with rows right now.
The whole effort was triggered because BinaryRow had too many assumptions
that were plain wrong for columnar. Now this PR adds TableRow that basically
has the same problem.
Schema version should be handled in the same fashion as rowid is handled
now. That is it should be passed as an additional parameter or field or
whatever. It should never be embedded into the row binary data. This way we
will avoid troubles for storage engines that do not need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
