ptupitsyn commented on code in PR #1548:
URL: https://github.com/apache/ignite-3/pull/1548#discussion_r1085067907
##########
modules/platforms/cpp/ignite/client/detail/node_connection.h:
##########
@@ -115,6 +115,7 @@ class node_connection : public
std::enable_shared_from_this<node_connection> {
}
}
+ m_logger->log_debug("Performing request: op=" +
std::to_string(int(op)) + ", req_id=" + std::to_string(reqId));
Review Comment:
Does this affect performance even when debug logging is disabled? String
concatenation is performed anyway, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
