denis-chudov commented on code in PR #1563:
URL: https://github.com/apache/ignite-3/pull/1563#discussion_r1085567130
##########
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -265,9 +265,6 @@ public static class Transactions {
/** Error of unexpected tx state on state change. */
public static final int TX_UNEXPECTED_STATE_ERR =
TX_ERR_GROUP.registerErrorCode(3);
- /** Failed to release a lock on a key. */
- public static final int RELEASE_LOCK_ERR =
TX_ERR_GROUP.registerErrorCode(4);
-
/** Failed to acquire a lock on a key due to a conflict. */
public static final int ACQUIRE_LOCK_ERR =
TX_ERR_GROUP.registerErrorCode(5);
Review Comment:
shouldnt we descrease the numbers of ACQUIRE_LOCK_ERR and following codes?
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -20,7 +20,9 @@
import static java.util.concurrent.CompletableFuture.completedFuture;
import static java.util.concurrent.CompletableFuture.failedFuture;
import static org.apache.ignite.internal.util.ExceptionUtils.withCause;
+import static org.apache.ignite.lang.ErrorGroups.Common.UNKNOWN_ERR;
Review Comment:
why UNKNOWN_ERR is deprecated? im not sure that it is good pattern to use
deprecated value, but if it is ok, the annotation should be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
