ygerzhedovich commented on code in PR #1501:
URL: https://github.com/apache/ignite-3/pull/1501#discussion_r1086611602
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -428,7 +431,8 @@ private CompletableFuture<AsyncSqlCursor<List<Object>>>
querySingle0(
InternalTransaction implicitTx =
implicitTxRequired ? txManager.begin() : null;
BaseQueryContext enrichedContext =
- implicitTxRequired ?
ctx.toBuilder().transaction(implicitTx).build() : ctx;
+ implicitTxRequired ?
ctx.toBuilder().transaction(implicitTx)
+
.transactionId(distributedSqlDisabled ? null : implicitTx.id()).build() : ctx;
Review Comment:
it looks ugly, let's try using prepared transaction object with all required
parts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
