xtern commented on code in PR #1501:
URL: https://github.com/apache/ignite-3/pull/1501#discussion_r1087069710
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -428,7 +431,8 @@ private CompletableFuture<AsyncSqlCursor<List<Object>>>
querySingle0(
InternalTransaction implicitTx =
implicitTxRequired ? txManager.begin() : null;
BaseQueryContext enrichedContext =
- implicitTxRequired ?
ctx.toBuilder().transaction(implicitTx).build() : ctx;
+ implicitTxRequired ?
ctx.toBuilder().transaction(implicitTx)
+
.transactionId(distributedSqlDisabled ? null : implicitTx.id()).build() : ctx;
Review Comment:
After some thought, I decided that this makes the code look cleaner and
easier to make the changes needed to enable distributive SQL (in IGNITE-17952).
So I decided to follow your suggestion and made `transactionId` mandatory,
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
