rpuch commented on code in PR #1578:
URL: https://github.com/apache/ignite-3/pull/1578#discussion_r1088639419
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java:
##########
@@ -561,7 +572,7 @@ private static byte[] rowBytes(@Nullable TableRow row) {
assert rowId.partitionId() == partitionId : rowId;
return busy(() -> {
- throwExceptionIfStorageInProgressOfRebalance(state.get(),
this::createStorageInfo);
+ throwExceptionIfStorageNotInRunnableState(state.get(),
this::createStorageInfo);
Review Comment:
Ok. How about adding a comment to the code to make sure that no confusion
arises when other people read this for the first time?
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java:
##########
@@ -561,7 +572,7 @@ private static byte[] rowBytes(@Nullable TableRow row) {
assert rowId.partitionId() == partitionId : rowId;
return busy(() -> {
- throwExceptionIfStorageInProgressOfRebalance(state.get(),
this::createStorageInfo);
+ throwExceptionIfStorageNotInRunnableState(state.get(),
this::createStorageInfo);
Review Comment:
Ok. How about adding a clarifying comment to the code to make sure that no
confusion arises when other people read this for the first time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
