ibessonov commented on code in PR #1597:
URL: https://github.com/apache/ignite-3/pull/1597#discussion_r1090624862
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##########
@@ -597,14 +604,13 @@ public void onDisappeared(ClusterNode member) {
}
private void scheduleRemoveFromLogicalTopology(CmgRaftService raftService,
ClusterNode node) {
- // TODO: delay should be configurable, see
https://issues.apache.org/jira/browse/IGNITE-16785
scheduledExecutor.schedule(() -> {
ClusterNode physicalTopologyNode =
clusterService.topologyService().getByConsistentId(node.name());
if (physicalTopologyNode == null ||
!physicalTopologyNode.id().equals(node.id())) {
raftService.removeFromCluster(Set.of(node));
}
- }, 0, TimeUnit.MILLISECONDS);
+ },
configuration.logicalTopologyRemovalDelayAfterDisappearance().value(),
TimeUnit.MILLISECONDS);
Review Comment:
Thank you! I still hope that one day we will revisit all configuration
names. And I mean all of them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
