sanpwc commented on code in PR #1572:
URL: https://github.com/apache/ignite-3/pull/1572#discussion_r1092518966
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -950,6 +994,8 @@ public void stop() {
busyLock.block();
+ metaStorageMgr.unregisterWatch(zonesWatchListener);
Review Comment:
To be honest we don't really need this. Unregister will just remove some
filters from the volatile meta storage state, that is useless in case of node
stop. I mean that given unregister isn't about distributed watch
de-registration. That also means that you don't need `private volatile
WatchListener zonesWatchListener; ` as an explicit variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
